Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix events for DEA models #687

Merged
merged 19 commits into from
Apr 19, 2019
Merged

Fix events for DEA models #687

merged 19 commits into from
Apr 19, 2019

Conversation

FFroehlich
Copy link
Member

Will add unittests.

Should probably add documentation that we assume events to be "impulse free" in a DAE context.

@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #687 into develop will increase coverage by 0.67%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #687      +/-   ##
===========================================
+ Coverage    72.77%   73.44%   +0.67%     
===========================================
  Files           49       49              
  Lines         7152     7171      +19     
===========================================
+ Hits          5205     5267      +62     
+ Misses        1947     1904      -43
Flag Coverage Δ
#cpp 70.07% <50%> (+0.92%) ⬆️
#python 83.68% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
src/forwardproblem.cpp 87.5% <ø> (-0.04%) ⬇️
src/solver_idas.cpp 44.36% <50%> (+9.9%) ⬆️
python/amici/__init__.py 83.63% <0%> (-1.82%) ⬇️
src/model_dae.cpp 51.85% <0%> (+10.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feaebd2...f198fbb. Read the comment docs.

@FFroehlich FFroehlich changed the title [WIP] Fix events for DEA models Fix events for DEA models Apr 18, 2019
@FFroehlich FFroehlich requested a review from dweindl April 18, 2019 02:22
@FFroehlich FFroehlich mentioned this pull request Apr 18, 2019
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added on purpose? BIN +12.6 KB (100%) tests/cpputest/testOptions.h5

tests/cpputest/testfunctions.cpp Outdated Show resolved Hide resolved
@FFroehlich FFroehlich merged commit 42181fa into develop Apr 19, 2019
@FFroehlich FFroehlich deleted the feature_dea_events branch April 19, 2019 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants