Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pysb initial condition parsing #669

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Fix pysb initial condition parsing #669

merged 2 commits into from
Mar 26, 2019

Conversation

FFroehlich
Copy link
Member

No description provided.

@FFroehlich FFroehlich requested a review from dweindl March 22, 2019 12:00
@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #669 into develop will increase coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #669      +/-   ##
===========================================
+ Coverage    72.94%   72.96%   +0.01%     
===========================================
  Files           48       48              
  Lines         6975     6976       +1     
===========================================
+ Hits          5088     5090       +2     
+ Misses        1887     1886       -1
Flag Coverage Δ
#cpp 69.49% <ø> (ø) ⬆️
#python 83.53% <50%> (+0.06%) ⬆️
Impacted Files Coverage Δ
python/amici/pysb_import.py 91.82% <50%> (+0.03%) ⬆️
python/amici/__init__.py 83.63% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52afff2...4c2fdcb. Read the comment docs.

@FFroehlich FFroehlich merged commit 16bb05b into develop Mar 26, 2019
@FFroehlich FFroehlich deleted the fix_pysb_init branch March 26, 2019 13:21
@dweindl dweindl mentioned this pull request Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants