-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate passing individual tables to amici_import_petab
#2464
Conversation
and replace deprecated `petab.Problem.from_files` in `amici.petab.cli.import_petab._main`. Fixes AMICI-dev#2460
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2464 +/- ##
===========================================
- Coverage 77.65% 77.61% -0.04%
===========================================
Files 324 324
Lines 20927 20933 +6
Branches 1464 1464
===========================================
- Hits 16250 16247 -3
- Misses 4674 4683 +9
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add tests for both calls?
the yaml-based one is used for the benchmark collection, added one for the deprecated call |
amici_import_petab
amici_import_petab
and replace deprecated
petab.Problem.from_files
inamici.petab.cli.import_petab._main
.Fixes #2460