Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate passing individual tables to amici_import_petab #2464

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jun 25, 2024

and replace deprecated petab.Problem.from_files in amici.petab.cli.import_petab._main.

Fixes #2460

and replace deprecated `petab.Problem.from_files` in `amici.petab.cli.import_petab._main`.

Fixes AMICI-dev#2460
@dweindl dweindl marked this pull request as ready for review June 25, 2024 14:17
@dweindl dweindl requested a review from a team as a code owner June 25, 2024 14:17
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 77.61%. Comparing base (474b473) to head (017ef66).
Report is 22 commits behind head on develop.

Files with missing lines Patch % Lines
python/sdist/amici/petab/cli/import_petab.py 0.00% 13 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2464      +/-   ##
===========================================
- Coverage    77.65%   77.61%   -0.04%     
===========================================
  Files          324      324              
  Lines        20927    20933       +6     
  Branches      1464     1464              
===========================================
- Hits         16250    16247       -3     
- Misses        4674     4683       +9     
  Partials         3        3              
Flag Coverage Δ
cpp 73.37% <0.00%> (-0.04%) ⬇️
cpp_python 34.08% <0.00%> (-0.01%) ⬇️
petab 36.64% <0.00%> (-0.02%) ⬇️
python 72.15% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/petab/cli/import_petab.py 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@dweindl dweindl self-assigned this Jun 25, 2024
Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add tests for both calls?

python/sdist/amici/petab/cli/import_petab.py Show resolved Hide resolved
python/sdist/amici/petab/cli/import_petab.py Show resolved Hide resolved
@dweindl
Copy link
Member Author

dweindl commented Jun 26, 2024

Maybe add tests for both calls?

the yaml-based one is used for the benchmark collection, added one for the deprecated call

@dweindl dweindl changed the title Deprecated passing individual tables to amici_import_petab Deprecate passing individual tables to amici_import_petab Jun 26, 2024
@dweindl dweindl merged commit 538fd59 into AMICI-dev:develop Jun 26, 2024
16 of 18 checks passed
@dweindl dweindl deleted the fix_2460 branch June 26, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated petab.Problem.from_files in amici.petab.cli.import_petab._main
2 participants