Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix execution of multiple event assignments from the same event #2431

Closed
wants to merge 3 commits into from

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented May 7, 2024

Fixes #2430

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.41%. Comparing base (41d19bb) to head (5d72df0).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2431      +/-   ##
===========================================
- Coverage    77.65%   73.41%   -4.24%     
===========================================
  Files          324      319       -5     
  Lines        20915    20748     -167     
  Branches      1464     1443      -21     
===========================================
- Hits         16241    15233    -1008     
- Misses        4671     5511     +840     
- Partials         3        4       +1     
Flag Coverage Δ
cpp 73.41% <100.00%> (-0.02%) ⬇️
cpp_python ?
petab ?
python 69.84% <100.00%> (-2.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/sdist/amici/sbml_import.py 78.58% <100.00%> (-1.15%) ⬇️

... and 29 files with indirect coverage changes

@dweindl
Copy link
Member Author

dweindl commented May 7, 2024

Invalid. See #2430 (comment)

@dweindl dweindl closed this May 7, 2024
@dweindl dweindl deleted the fix_2430_simultaneous_ea branch May 7, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant