Support event-assignments to compartments that aren't rate rule targets #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Event-assignments to compartments weren't supported yet, now they are. Compartments that are targets of event assignments are now processed as "species", the same way as it is already done for parameters that are targets of event assignments. Closes AMICI-dev#2424.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2425 +/- ##
===========================================
- Coverage 77.66% 77.65% -0.02%
===========================================
Files 324 324
Lines 20902 20915 +13
Branches 1464 1464
===========================================
+ Hits 16233 16241 +8
- Misses 4666 4671 +5
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dweindl
changed the title
FFroehlich
approved these changes
May 7, 2024
Co-authored-by: Fabian Fröhlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event-assignments to compartments weren't supported yet, now they are.
Compartments that are targets of event assignments are now processed as "species", the same way as it is already done for parameters that are targets of event assignments.
Closes #2424.