Faster generation of drootdt_total for models without state-dependent root functions #2417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… root functions Don't compute things we don't need. For my test model, this reduces code generation time from 76s to 12s (-83%).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2417 +/- ##
===========================================
- Coverage 77.66% 77.59% -0.08%
===========================================
Files 324 324
Lines 20913 20913
Branches 1464 1464
===========================================
- Hits 16243 16227 -16
- Misses 4667 4683 +16
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't compute things we don't need.
For my test model, this reduces code generation time from 76s to 12s (-83%).