Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake: cannot create directory: /cmake/Amici #2389

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Mar 28, 2024

Fixes cmake-install failures during model import in cases where BLAS was not found via FindBLAS.

Needs a prettier solution at some point, but it does the job for now.

@dweindl dweindl requested a review from a team as a code owner March 28, 2024 07:24
Fixes cmake-install failures during model import in cases where BLAS was not found via FindBLAS.

Needs a prettier solution at some point, but it does the job for now.
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.64%. Comparing base (790ab44) to head (195588e).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2389      +/-   ##
===========================================
- Coverage    77.67%   77.64%   -0.04%     
===========================================
  Files          324      324              
  Lines        20872    20872              
  Branches      1458     1458              
===========================================
- Hits         16213    16206       -7     
- Misses        4656     4663       +7     
  Partials         3        3              
Flag Coverage Δ
cpp 73.40% <ø> (-0.04%) ⬇️
cpp_python 34.21% <ø> (ø)
petab 36.81% <ø> (ø)
python 72.17% <ø> (-0.04%) ⬇️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@dweindl dweindl added this pull request to the merge queue Mar 28, 2024
Merged via the queue into AMICI-dev:develop with commit ebf5eef Mar 28, 2024
19 of 20 checks passed
@dweindl dweindl deleted the fix_cmake_findblas branch April 16, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants