Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always include timepoints in NaN/Inf warnings #2347

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Mar 4, 2024

Closes #2328

@dweindl dweindl requested a review from a team as a code owner March 4, 2024 20:48
@dweindl dweindl self-assigned this Mar 4, 2024
@dweindl dweindl linked an issue Mar 4, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 56 lines in your changes are missing coverage. Please review.

Project coverage is 36.79%. Comparing base (e8852be) to head (2deb567).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2347       +/-   ##
============================================
- Coverage    77.88%   36.79%   -41.09%     
============================================
  Files          324      103      -221     
  Lines        20731    14711     -6020     
  Branches      1449     1373       -76     
============================================
- Hits         16146     5413    -10733     
- Misses        4582     8992     +4410     
- Partials         3      306      +303     
Flag Coverage Δ
cpp ?
cpp_python ?
petab 36.79% <12.50%> (-0.07%) ⬇️
python ?
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
include/amici/model.h 36.84% <ø> (-36.85%) ⬇️
src/amici.cpp 35.29% <100.00%> (-45.79%) ⬇️
src/model_dae.cpp 0.00% <0.00%> (-31.17%) ⬇️
src/model_ode.cpp 37.15% <0.00%> (-28.90%) ⬇️
src/solver_cvodes.cpp 21.85% <12.50%> (-47.67%) ⬇️
src/solver_idas.cpp 0.00% <0.00%> (-37.10%) ⬇️
src/model.cpp 34.52% <18.51%> (-51.73%) ⬇️

... and 282 files with indirect coverage changes

src/model.cpp Outdated Show resolved Hide resolved
Co-authored-by: Fabian Fröhlich <[email protected]>
src/model.cpp Outdated Show resolved Hide resolved
@dweindl dweindl merged commit 777deb0 into AMICI-dev:develop Mar 5, 2024
16 of 20 checks passed
@dweindl dweindl deleted the 2328_warnings_time branch March 5, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always include timepoints in NaN/Inf warnings
2 participants