Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReturnDataView AttributeError: messages #2341

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Mar 4, 2024

  • Make log messages from ReturnData available through ReturnDataView.
  • Add LogItem.__repr__

Closes #2331.

* Make log messages from ReturnData available through ReturnDataView.
* Add `LogItem.__repr__`

Closes AMICI-dev#2331.
@dweindl dweindl requested a review from a team as a code owner March 4, 2024 12:31
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 36.86%. Comparing base (3a6b0df) to head (3972c41).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2341       +/-   ##
============================================
- Coverage    77.88%   36.86%   -41.03%     
============================================
  Files          324      103      -221     
  Lines        20729    14693     -6036     
  Branches      1449     1373       -76     
============================================
- Hits         16144     5416    -10728     
- Misses        4582     8970     +4388     
- Partials         3      307      +304     
Flag Coverage Δ
cpp ?
cpp_python ?
petab 36.86% <66.66%> (+<0.01%) ⬆️
python ?
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/sdist/amici/numpy.py 49.55% <66.66%> (-37.83%) ⬇️

... and 288 files with indirect coverage changes

@dweindl dweindl self-assigned this Mar 4, 2024
@dweindl dweindl merged commit 1ab1d55 into AMICI-dev:develop Mar 4, 2024
16 of 20 checks passed
@dweindl dweindl deleted the fix_2331_msgs branch March 4, 2024 14:22
@dweindl dweindl linked an issue Mar 4, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReturnDataView AttributeError: messages
2 participants