Allow setting MaxConvFails and MaxNonlinIters on solvers #2335

dweindl · 2024-02-29T07:47:08Z

See CVodeSetMaxConvFails and CVodeSetMaxNonlinIters.

Closes #2333.

See [CVodeSetMaxConvFails](https://sundials.readthedocs.io/en/latest/cvodes/Usage/SIM.html#c.CVodeSetMaxConvFails) and [CVodeSetMaxNonlinIters](https://sundials.readthedocs.io/en/latest/cvodes/Usage/SIM.html#c.CVodeSetMaxNonlinIters). Closes AMICI-dev#2333.

codecov · 2024-02-29T08:08:05Z

Codecov Report

Attention: Patch coverage is 86.95652% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 77.90%. Comparing base (4782cad) to head (954e523).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2335      +/-   ##
===========================================
+ Coverage    77.88%   77.90%   +0.01%     
===========================================
  Files          324      324              
  Lines        20680    20723      +43     
  Branches      1440     1448       +8     
===========================================
+ Hits         16107    16144      +37     
- Misses        4570     4576       +6     
  Partials         3        3

Flag	Coverage Δ
cpp	`73.70% <86.95%> (+0.02%)`	⬆️
cpp_python	`34.35% <26.08%> (-0.02%)`	⬇️
petab	`36.87% <22.72%> (-0.04%)`	⬇️
python	`72.47% <67.39%> (-0.02%)`	⬇️
sbmlsuite	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
include/amici/serialization.h	`96.65% <100.00%> (+0.03%)`	⬆️
include/amici/solver.h	`100.00% <ø> (ø)`
include/amici/solver_cvodes.h	`100.00% <ø> (ø)`
include/amici/solver_idas.h	`100.00% <ø> (ø)`
src/hdf5.cpp	`89.80% <100.00%> (+0.15%)`	⬆️
src/newton_solver.cpp	`70.63% <100.00%> (-0.24%)`	⬇️
src/solver.cpp	`75.45% <88.23%> (+0.23%)`	⬆️
src/solver_cvodes.cpp	`69.51% <75.00%> (+0.07%)`	⬆️
src/solver_idas.cpp	`37.09% <75.00%> (+0.55%)`	⬆️

dweindl requested a review from a team as a code owner February 29, 2024 07:47

dweindl linked an issue Feb 29, 2024 that may be closed by this pull request

Allow setting MaxConvFails #2333

Closed

dweindl self-assigned this Feb 29, 2024

hdf5

954e523

FFroehlich approved these changes Mar 3, 2024

View reviewed changes

dweindl merged commit 239ce2c into AMICI-dev:develop Mar 4, 2024
20 checks passed

dweindl deleted the feature_2333_solveropts branch March 4, 2024 06:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow setting MaxConvFails and MaxNonlinIters on solvers #2335

Allow setting MaxConvFails and MaxNonlinIters on solvers #2335

dweindl commented Feb 29, 2024

codecov bot commented Feb 29, 2024 •

edited

Loading

Allow setting MaxConvFails and MaxNonlinIters on solvers #2335

Allow setting MaxConvFails and MaxNonlinIters on solvers #2335

Conversation

dweindl commented Feb 29, 2024

codecov bot commented Feb 29, 2024 • edited Loading

Codecov Report

codecov bot commented Feb 29, 2024 •

edited

Loading