Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: update BLAS detection #2318

Merged
merged 1 commit into from
Feb 26, 2024
Merged

CMake: update BLAS detection #2318

merged 1 commit into from
Feb 26, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Feb 26, 2024

* Search for 64bit BLAS if supported by CMake.

* On apple, try accelerate if nothing else was specified.

  Use the new interface (https://developer.apple.com/documentation/accelerate/blas). Fixes AMICI-dev#2286.
@dweindl dweindl self-assigned this Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.77%. Comparing base (8b324bc) to head (101d2ca).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2318      +/-   ##
===========================================
- Coverage    77.78%   77.77%   -0.02%     
===========================================
  Files          318      318              
  Lines        20534    20534              
  Branches      1436     1436              
===========================================
- Hits         15973    15970       -3     
- Misses        4558     4561       +3     
  Partials         3        3              
Flag Coverage Δ
cpp 73.56% <ø> (-0.02%) ⬇️
cpp_python 34.00% <ø> (ø)
petab 36.39% <ø> (ø)
python 72.33% <ø> (-0.01%) ⬇️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@dweindl dweindl marked this pull request as ready for review February 26, 2024 10:59
@dweindl dweindl requested a review from a team as a code owner February 26, 2024 10:59
CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
@dweindl dweindl added this pull request to the merge queue Feb 26, 2024
@FFroehlich FFroehlich removed this pull request from the merge queue due to a manual request Feb 26, 2024
@dweindl dweindl added this pull request to the merge queue Feb 26, 2024
@dweindl dweindl removed this pull request from the merge queue due to a manual request Feb 26, 2024
@dweindl dweindl merged commit 780d767 into AMICI-dev:develop Feb 26, 2024
19 of 20 checks passed
@dweindl dweindl deleted the cmake_blas branch February 26, 2024 18:56
@dweindl dweindl linked an issue Mar 4, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'cblas_dgemm' is deprecated: first deprecated in macOS 13.3
2 participants