Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitignore to model directories #2301

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Feb 22, 2024

Add a .gitignore file to the amici-generated model directory to exclude the auto-generated files from version control.

Closes #2300.

Add a `.gitignore` file to the amici-generated model directory to exclude the auto-generated files from version control.

Closes AMICI-dev#2300.
@dweindl dweindl linked an issue Feb 22, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (67d478c) 77.87% compared to head (8f7983a) 77.85%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2301      +/-   ##
===========================================
- Coverage    77.87%   77.85%   -0.03%     
===========================================
  Files          318      318              
  Lines        20529    20534       +5     
  Branches      1436     1436              
===========================================
- Hits         15987    15986       -1     
- Misses        4539     4545       +6     
  Partials         3        3              
Flag Coverage Δ
cpp 73.63% <100.00%> (-0.03%) ⬇️
cpp_python 34.00% <100.00%> (+0.01%) ⬆️
petab 36.39% <100.00%> (+0.02%) ⬆️
python 72.41% <100.00%> (-0.03%) ⬇️
sbmlsuite ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/sdist/amici/de_export.py 92.14% <100.00%> (+0.03%) ⬆️

... and 2 files with indirect coverage changes

@dweindl dweindl marked this pull request as ready for review February 22, 2024 11:36
@dweindl dweindl requested a review from a team as a code owner February 22, 2024 11:36
Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl added this pull request to the merge queue Feb 22, 2024
Merged via the queue into AMICI-dev:develop with commit 4334557 Feb 22, 2024
25 of 26 checks passed
@dweindl dweindl deleted the ft_2300_gitignore branch February 28, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gitignore amici model directories
2 participants