Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid type error when loading antimony model from file #2281

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jan 31, 2024

pathlib.Path -> str

@dweindl dweindl requested a review from a team as a code owner January 31, 2024 09:12
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (51b0219) 77.75% compared to head (06c028f) 77.75%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2281   +/-   ##
========================================
  Coverage    77.75%   77.75%           
========================================
  Files          318      318           
  Lines        20510    20510           
  Branches      1436     1436           
========================================
  Hits         15947    15947           
  Misses        4560     4560           
  Partials         3        3           
Flag Coverage Δ
cpp 73.53% <0.00%> (ø)
cpp_python 33.99% <0.00%> (ø)
petab 36.39% <0.00%> (ø)
python 72.30% <0.00%> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/sdist/amici/antimony_import.py 94.11% <0.00%> (ø)

@dweindl dweindl added this pull request to the merge queue Jan 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2024
@dweindl dweindl merged commit 26bb902 into AMICI-dev:develop Feb 1, 2024
19 of 20 checks passed
@dweindl dweindl deleted the fix_antimony_from_file branch February 1, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants