Add an abstract class for Tokenizer #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that #40 changed the implementation to output only token IDs instead of strings. Will need to update this PR with the new changes. |
qihqi
reviewed
Apr 25, 2024
JoeZijunZhou
approved these changes
Apr 25, 2024
FanhaiLu1
requested changes
Apr 26, 2024
FanhaiLu1
approved these changes
Apr 26, 2024
|
Thanks for the PR, this looks great. I'd appreciate if you can also add unittests (or update existing ones) for the changes. |
bhavya01
added a commit
to bhavya01/JetStream
that referenced
this pull request
May 1, 2024
* Add an abstract class for tokenizer * Add sentence piece tokenizer as a subclass of Tokenizer * Fix decode method for SentencePieceTokenizer * Fix circular import issue * fix type annotations * fix linting issues * Format files using pyink * Update the tokenizer decode interface to return ids instead of str * format using pyink * Move Tokenizer class to a tokenizer_api.py file * Update engine.build_tokenizer method to return SentencePieceTokenizer by default
jwyang-google
pushed a commit
that referenced
this pull request
May 6, 2024
* Add an abstract class for tokenizer * Add sentence piece tokenizer as a subclass of Tokenizer * Fix decode method for SentencePieceTokenizer * Fix circular import issue * fix type annotations * fix linting issues * Format files using pyink * Update the tokenizer decode interface to return ids instead of str * format using pyink * Move Tokenizer class to a tokenizer_api.py file * Update engine.build_tokenizer method to return SentencePieceTokenizer by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.