Skip to content

(Minor) Move payerKey/payerNote to OfferPaymentMetaData class #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pm47 merged 1 commit into from
Oct 17, 2025
Merged

(Minor) Move payerKey/payerNote to OfferPaymentMetaData class #821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions modules/core/src/commonMain/kotlin/fr/acinq/lightning/payment/OfferPaymentMetadata.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ sealed class OfferPaymentMetadata {
abstract val createdAtSeconds: Long
abstract val relativeExpirySeconds: Long?
val paymentHash: ByteVector32 get() = preimage.sha256()
abstract val payerKey: PublicKey?
abstract val payerNote: String?

/** Encode into a format that can be stored in the payments DB. */
fun encode(): ByteVector {
Expand Down Expand Up @@ -79,8 +81,8 @@ sealed class OfferPaymentMetadata {
override val offerId: ByteVector32,
override val amount: MilliSatoshi,
override val preimage: ByteVector32,
val payerKey: PublicKey,
val payerNote: String?,
override val payerKey: PublicKey,
override val payerNote: String?,
val quantity: Long,
val createdAtMillis: Long
) : OfferPaymentMetadata() {
Expand Down Expand Up @@ -121,8 +123,8 @@ sealed class OfferPaymentMetadata {
override val createdAtSeconds: Long,
override val relativeExpirySeconds: Long?,
val description: String?,
val payerKey: PublicKey?,
val payerNote: String?,
override val payerKey: PublicKey?,
override val payerNote: String?,
val quantity: Long?,
) : OfferPaymentMetadata() {
override val version: Byte get() = 2
Expand Down