(Minor) Move payerKey/payerNote to OfferPaymentMetaData class#821
Merged
(Minor) Move payerKey/payerNote to OfferPaymentMetaData class#821
payerKey/payerNote to OfferPaymentMetaData class#821Conversation
This removed boiler plate code when integrating the library.
pm47
changed the title
payerKey/payerNote to OfferPaymentData classpayerKey/payerNote to OfferPaymentMetaData class
t-bast
approved these changes
Oct 17, 2025
dpad85
added a commit
to ACINQ/phoenix
that referenced
this pull request
Oct 17, 2025
See ACINQ/lightning-kmp#821 Also limit the description input to 64 chars for Bolt12 offers as the description + payer note cannot exceed 64 chars.
dpad85
added a commit
to ACINQ/phoenix
that referenced
this pull request
Oct 23, 2025
This commit upgrades lightning-kmp to v1.11.0, which brings taproot channels to Phoenix. It also updates kotlin and cleans up legacy code. Notably, the tools for the legacy channel data backup have been removed, and the import-channel-data helper can be removed. The spend-from-channel-address screen has been disabled. The import-channel-data screen is obsolete and has been removed. * Use abstract payerKey and payerNote in offer metadata See ACINQ/lightning-kmp#821 Also limit the description input to 64 chars for Bolt12 offers as the description + payer note cannot exceed 64 chars. --------- Co-authored-by: Robbie Hanson <304604+robbiehanson@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes boiler plate code when integrating the library.