Skip to content

PRXT - fix: add accessible label to header search #1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
punk6529 wants to merge 1 commit into from
Closed

PRXT - fix: add accessible label to header search #1414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions __tests__/components/header/HeaderSearchModal.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,15 @@ describe("HeaderSearchModal", () => {
jest.clearAllMocks();
});

it("associates the search input with an accessible label", () => {
setup();
expect(
screen.getByRole("textbox", {
name: "Search",
})
).toBeInTheDocument();
});

it("calls onClose when escape is pressed", () => {
const { onClose } = setup();
escapeCb();
Expand All @@ -88,7 +97,7 @@ describe("HeaderSearchModal", () => {

it("renders search results when query returns items", () => {
setup();
const input = screen.getByRole("textbox");
const input = screen.getByRole("textbox", { name: "Search" });
fireEvent.change(input, { target: { value: "abc" } });
expect(screen.getByTestId("item")).toBeInTheDocument();
});
Expand All @@ -101,7 +110,7 @@ describe("HeaderSearchModal", () => {

it("navigates on enter key", () => {
const { push } = setup();
const input = screen.getByRole("textbox");
const input = screen.getByRole("textbox", { name: "Search" });
fireEvent.change(input, { target: { value: "alice" } });
enterCb();
expect(push).toHaveBeenCalled();
Expand Down
4 changes: 4 additions & 0 deletions components/header/header-search/HeaderSearchModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,8 +283,12 @@ export default function HeaderSearchModal({
clipRule="evenodd"
/>
</svg>
<label className="tw-sr-only" htmlFor="header-search-input">
Search
</label>
<input
ref={inputRef}
id="header-search-input"
type="text"
required
autoComplete="off"
Expand Down