Skip to content

PRXT - fix: add accessible label to header search#1414

Closed
punk6529 wants to merge 1 commit intomainfrom
codex/add-accessible-label-to-search-input
Closed

PRXT - fix: add accessible label to header search#1414
punk6529 wants to merge 1 commit intomainfrom
codex/add-accessible-label-to-search-input

Conversation

@punk6529
Copy link
Copy Markdown
Contributor

Summary

  • add a visually hidden label for the header search input to keep the accessible name in sync with the placeholder
  • update the HeaderSearchModal tests to cover the accessible label and use the labelled query helpers

Testing

  • CI=1 npm run test -- --runTestsByPath tests/components/header/HeaderSearchModal.test.tsx
  • npm run lint
  • npm run type-check (fails due to pre-existing type errors in the repository)

https://chatgpt.com/codex/tasks/task_e_68c941044f1c8321b9051d7b2cf7f6cd

Signed-off-by: OpenAI Assistant <openai-assistant@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

@prxt6529 prxt6529 changed the title fix: add accessible label to header search PRXT - fix: add accessible label to header search Oct 7, 2025
@prxt6529
Copy link
Copy Markdown
Collaborator

prxt6529 commented Oct 7, 2025

Will be done in #1516

@prxt6529 prxt6529 closed this Oct 7, 2025
@prxt6529 prxt6529 deleted the codex/add-accessible-label-to-search-input branch October 7, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants