Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to create presets/ CLI issue #78

Closed
650-P opened this issue Sep 11, 2022 · 2 comments
Closed

How to create presets/ CLI issue #78

650-P opened this issue Sep 11, 2022 · 2 comments

Comments

@650-P
Copy link

650-P commented Sep 11, 2022

  1. I know this could be sound stupid but how do you create presets? I cant see it anywhere in this repo. Can anyone point it out for me if i was just being blind.
  2. the cli doesnt read ripple as a valid effect parameter
@4JX
Copy link
Owner

4JX commented Sep 11, 2022

  1. Click on the presets tab, input any combination of colors + effect + options and tap the + sign.

  2. Ah I forgot to add it, I should untangle the codebase a bit sometime to automate this

@650-P
Copy link
Author

650-P commented Sep 12, 2022

  1. thx, I think the color of the + and - button are too dark, I can barely see it even after you told me there is a + sign
  2. presets with ripple doesn't work properly, it loads in the colors but the effect becomes static when trying to load the preset

this program is so much better than lenovo's bs, keep it up <3

4JX added a commit that referenced this issue Oct 13, 2022
@4JX
Fix #78
461a77d
@4JX 4JX closed this as completed in 5a6cc0f Nov 5, 2022
4JX added a commit that referenced this issue Jun 22, 2023
@4JX @mariobalanica @rslarson
v0.19.0 (#117)
ff18392 
* Add support for 2022 keyboards

* Move effects to separate files

* Pass the generated profile as-is

* Smooth wave code dedup

* Fix #78

* Update the cli code

* Update deps

* Unify the logic for distinguishing effects that take input colours

* Make speed reach beyond stock

* Append json extension when saving a profile

* Change wording from preset to profile

* (Hopefully) Reduce resource usage for Fade

* Allow custom fps for AmbientLight

Solves #71

* Remove restriction for Temperature on Windows

* Finishing touches for 0.18.0

* Fix cli speed cap

* Fix ambient not respecting fps setting

Also update its dependencies

* Nix build system

* Fix execution issues on nix build

* Kinda fix shell env

* Nuke gui code

* Rework the CLI

* Fix #98

* Clamp AmbientLight fps

* Move driver to its own crate

* Update hidapi

* Better error handlng

* Refactor the zone representation

* Test UI

* #96 and misc README changes

* Pass CLI instructions to the GUI

* UI Progress

* Probably final layout

* Allow starting the GUI hidden

* AmbientLight FPS control

* In-memory profile management

* Error modals

* Update flake.nix

* Remove custom effect (unused) speed

* AmbientLight stuffs

* Profile and effect load/save management

* Update mod.rs

* Update workflows

* Windows fixing

* Linux dep fixing

* Move GUI startup code to a separate function

* Cli fixes

* Fix speed range crash

* Switch to spaces

* Change highlight color

* Update version

* Update cli.rs

* Clippy

* Switch to upstream clap

* Ambientlight improvements

* Update workflows

* Update checking capabilities

* Clippy

* Fix typo in update check code

* Revert using run-vcpkg in workflows

* Fix speed range issue

* Less convoluted settings

* Update workflows

* Update readme

* Use rdev

* Update compile-rust.yml

* Update compile-rust.yml

* Misc cleanup

* Better Ripple

* Revert to libusb

* Feature parity with old UI

* Update workflows

* Re include libusb in workflows

* Update temperature.rs

* Fix CPU usage and first boot lights update

* Profile switching bounds check

* Remove useless impl from CustomEffectState

* Revert to device-query

* Fixes

* Add default back to speed

* Remove update check code

Finicky at best and most likely prone to breaking

* Update deps

* Update vcpkg

* Adding support for 2023 models (#115)

* Adding support for 2023 models

Tested on a Legion 5 Slim:

```
System Information
        Manufacturer: LENOVO
        Product Name: 82Y9
        Version: Legion Slim 5 16APH8
        Serial Number: <Redacted>
        UUID: <Redacted>
        Wake-up Type: Power Switch
        SKU Number: LENOVO_MT_82Y9_BU_idea_FM_Legion Slim 5 16APH8
        Family: Legion Slim 5 16APH8

```

* fixing minor typo in README

* Fix device arr length

* Update version

* Fix release CI

---------

Co-authored-by: Mario Bălănică <[email protected]>
Co-authored-by: rslarson <[email protected]>
Co-authored-by: pavelsevcik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@650-P @4JX