Skip to content

Unable to Save an effect #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AtlasXT9 opened this issue Aug 26, 2024 · 8 comments
Closed

Unable to Save an effect #169

AtlasXT9 opened this issue Aug 26, 2024 · 8 comments

Comments

@AtlasXT9
Copy link

like the profiles that show after you save them, i want to save effects that i create to use on the fly, but unable to do so, only able to run them from the effects tab.
Screenshot 2024-08-26 181506
also unable to save effects altogether.
the readme says that i can use effects from GUI or double click on the file to do so, but even after i tell to open with legion RGB, nothing works. please help out, i really want to make some cool custom effects like Asus has on their laptops
@quicquid @jValdron @pavelsevcik @mariobalanica @rslarson #

@4JX
Copy link
Owner

4JX commented Aug 26, 2024

Do not ping every contributor, that just annoys unrelated people that have added code at some point.

i want to save effects that i create to use on the fly, but unable to do so, only able to run them from the effects tab.
Screenshot 2024-08-26 181506

also unable to save effects altogether.

There's no effect "saving" functionality because there's also no way to create them within the app. You're supposed to edit the text yourself and load the files.

from GUI or double click on the file to do so

You can load them through the app, but not via the "open with" dialog. That I might be able to improve.

@AtlasXT9
Copy link
Author

AtlasXT9 commented Aug 29, 2024

@4JX i have another question, in the Christmas effect it starts with a very smooth wave from side to side in a very smooth manner. i want to do that in while writing a json file but unable to do that, please allow to set a slow smooth wave (single color) and in the breath

WhatsApp.Video.2024-08-29.at.20.31.01_7b6e87b6.mp4

i have attached a video, it looks a lot smoother in real. i want to do something like that, please help out brother!!
more precisely, i want to do a single color wave!
i also request for more increments in wave and smooth wave speed.
i also request - breathing effect, how about breath into different color sets? that would be very cool!

@4JX
Copy link
Owner

4JX commented Aug 29, 2024

You can do that with the swipe effect:
image

Or for more complex movement/color shifting custom effects can do the job:

{
	"effect_steps": [
		{"rgb_array": [255, 255, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], "step_type": "Transition", "brightness": 2, "steps": 100, "delay_between_steps": 5, "sleep": 0},
		{"rgb_array": [0, 0, 0, 255, 255, 0, 0, 0, 0, 0, 0, 0], "step_type": "Transition", "brightness": 2, "steps": 100, "delay_between_steps": 5, "sleep": 0},
		{"rgb_array": [0, 0, 0, 0, 0, 0, 255, 255, 0, 0, 0, 0], "step_type": "Transition", "brightness": 2, "steps": 100, "delay_between_steps": 5, "sleep": 0},
		{"rgb_array": [0, 0, 0, 0, 0, 0, 0, 0, 0, 255, 255, 0], "step_type": "Transition", "brightness": 2, "steps": 100, "delay_between_steps": 5, "sleep": 0},
		{"rgb_array": [0, 0, 0, 0, 0, 0, 255, 255, 0, 0, 0, 0], "step_type": "Transition", "brightness": 2, "steps": 100, "delay_between_steps": 5, "sleep": 0},
		{"rgb_array": [0, 0, 0, 255, 255, 0, 0, 0, 0, 0, 0, 0], "step_type": "Transition", "brightness": 2, "steps": 100, "delay_between_steps": 5, "sleep": 0}
	],
	"should_loop": true
}

@AtlasXT9
Copy link
Author

hey can we loop for some iterations? like i want to loop for 10 iterations and move on to next effect? how to speed up the above effect? reduce steps?
also can you please add an option to save and delete effects like we can save and delete profiles, i want to be able to use them on the fly, dont want to keep going into effects and searching for json file again and again pls pls! thanks for the help!!🫡

1 similar comment
@AtlasXT9
Copy link
Author

hey can we loop for some iterations? like i want to loop for 10 iterations and move on to next effect? how to speed up the above effect? reduce steps?
also can you please add an option to save and delete effects like we can save and delete profiles, i want to be able to use them on the fly, dont want to keep going into effects and searching for json file again and again pls pls! thanks for the help!!🫡

@4JX
Copy link
Owner

4JX commented Sep 2, 2024

hey can we loop for some iterations? like i want to loop for 10 iterations and move on to next effect?

You'd have to copy+paste that specific section you want to repeat for as many loops as you want.

how to speed up the above effect? reduce steps?

You can reduce the step count, meaning bigger jumps, or the time between steps, leading to smaller changes per step

also can you please add an option to save and delete effects

Yes, that's something I'll see about implementing

4JX added a commit that referenced this issue Dec 7, 2024
4JX added a commit that referenced this issue Dec 7, 2024
@4JX
Copy link
Owner

4JX commented Dec 7, 2024

Got around to doing this, you can test it in https://github.com/4JX/L5P-Keyboard-RGB/actions/runs/12216300969

Make sure you backup your settings.json file first, made some changes to the format to accommodate the new functionality and things may still change for the release.

4JX added a commit that referenced this issue Jan 2, 2025
4JX added a commit that referenced this issue Jan 2, 2025
@4JX
Copy link
Owner

4JX commented Jan 2, 2025

@4JX 4JX closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants