RELEASE 3.7-beta1 #1115
Merged
RELEASE 3.7-beta1 #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidor
reviewed
Sep 13, 2019
gateway/src/apicast/version.lua
Outdated
| @@ -1 +1 @@ | |||
| return "3.6.0" | |||
| return "3.7.0" | |||
There was a problem hiding this comment.
We should use 3.7.0-beta1.
We switch to 3.7.0 in the CR because CRs can become final.
davidor
reviewed
Sep 13, 2019
| @@ -4,7 +4,7 @@ All notable changes to this project will be documented in this file. | |||
| The format is based on [Keep a Changelog](http://keepachangelog.com/) | |||
| and this project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|
|||
| ## [Unreleased] | |||
| ## [3.7.0-beta1]- 2019-09-13 | |||
There was a problem hiding this comment.
There are a couple of lines at the end of the changelog that need to be modified too. Like in this commit of a previous beta version: 49e639d
This commit add the way to get the original request information on logging policy to be able to log full request information. Related to Issue 3scale#1082 Signed-off-by: Eloy Coto <[email protected]>
Signed-off-by: Eloy Coto <[email protected]>
Due to liquid filter was using ngx.ctx instead of the original context, the value mismatch and a valid content can't be used. This commit refactor the operations to always use context instead context.request Signed-off-by: Eloy Coto <[email protected]>
Logging: Added target host on logging policy.
Fix various typos. Added some required fields. Add description to operations. Signed-off-by: Eloy Coto <[email protected]>
There was an item in the changelog introduced by error. The policy order feature is not in this branch.
Signed-off-by: Eloy Coto <[email protected]>
Changelog: Update 3.6 items
Some users complained about that path on upstream can't be changed and a global rewrite url will not work due each API backend is different, this policy will update the request path to the liquid value. Signed-off-by: Eloy Coto <[email protected]>
Signed-off-by: Eloy Coto <[email protected]>
Signed-off-by: Eloy Coto <[email protected]>
Signed-off-by: Eloy Coto <[email protected]>
Signed-off-by: Eloy Coto <[email protected]>
Signed-off-by: Eloy Coto <[email protected]>
Routing policy: Add a way to replace the path on routing policy
Due to the changes made in the routing policy to be able to modify request path the query args was appended, and in this case, unexcaped to the upstream repo. This change adds a resty/url_helper function; this code will be moved to resty-url project in the following weeks. Signed-off-by: Eloy Coto <[email protected]>
Routing: Fix query args on replace_path
If the URL for the upstream has a path, with the combination of
replace_path feature, the path the will be overwritten, and the expected
behaviour will not work as expected.
Example config:
```
{
"url": "http://echo-api.3scale.net/test/",
"condition": {
"operations": [
{
"match": "path",
"op": "matches",
"value": "/echo/.*|/echo/?"
}
]
},
"replace_path": "{{original_request.path | remove_first: '/echo'}}"
}
```
Calling to
:8080/echo/x?user=1
Without the change will call to `http://echo-api.3scale.net/x?user=1`
With this change the target will be `http://echo-api.3scale.net/test/x?user=1`
Signed-off-by: Eloy Coto <[email protected]>
Routing Policy: Fix upstream selector base path
Signed-off-by: Eloy Coto <[email protected]>
davidor
approved these changes
Oct 2, 2019
|
@eloycoto Travis fails because the 3.7.0-beta1 tag has not been created, so we can merge this and create the tag after 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eloy Coto [email protected]