Logging: Added target host on logging policy. #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidor
reviewed
Sep 13, 2019
| @@ -77,6 +77,7 @@ local function get_request_context(context) | |||
| } | |||
|
|
|||
| ctx.service = context.service or {} | |||
| ctx.service.host = context.host | |||
There was a problem hiding this comment.
I think this modifies the host attr for the service meaning that every request for that service will be affected.
There was a problem hiding this comment.
This happens on log_by_lua block, so it only modifies when the request finishes, so nothing is affected no?
eloycoto
force-pushed
the
ServiceHost
branch
from
60783dd to
8329da5
Compare
This commit add the way to get the original request information on logging policy to be able to log full request information. Related to Issue 3scale#1082 Signed-off-by: Eloy Coto <[email protected]>
Signed-off-by: Eloy Coto <[email protected]>
Due to liquid filter was using ngx.ctx instead of the original context, the value mismatch and a valid content can't be used. This commit refactor the operations to always use context instead context.request Signed-off-by: Eloy Coto <[email protected]>
eloycoto
force-pushed
the
ServiceHost
branch
from
87efbea to
605eadd
Compare
davidor
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit add the way to get the target host on logging policy without
getting request headers.
Signed-off-by: Eloy Coto [email protected]
Related to #1082