support chart: update grafana chart 6.61.2 to 7.3.7 (grafana 10.1.5 to 10.4.0)#3920
Merged
consideRatio merged 1 commit into2i2c-org:mainfrom Apr 9, 2024
Merged
Conversation
Contributor
|
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deploymentsNo production hub upgrades will be triggered |
consideRatio
force-pushed
the
pr/update-grafana
branch
from
2bfbd7c to
f566e55
Compare
consideRatio
force-pushed
the
pr/update-grafana
branch
from
f566e55 to
2045211
Compare
GeorgianaElena
approved these changes
Apr 9, 2024
Member
GeorgianaElena
left a comment
GeorgianaElena
left a comment
There was a problem hiding this comment.
Thanks for getting to the bottom of this @consideRatio
Contributor
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/8613023738 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a breaking change for us now, grafana itself still supports our dashboard definitions from jupyterhub/grafana-dashboards, and the chart major version bump relates to a for us unused chart configuration.
There were upgrade errors stemming from grafana introducing (without a major version bump, but should have been!) a strict check for secrets being passed introduced in chart version 7.1.0 - this PR handles that by disabling the (too) strict check - see Yuvi's comment for example in #3482 (comment), which I also align with.