Skip to content

Bumping helm chart dependency versions: support#3482

Merged
yuvipanda merged 7 commits intomasterfrom
bump-helm-deps/support/hEtX
Jan 17, 2024
Merged

Bumping helm chart dependency versions: support#3482
yuvipanda merged 7 commits intomasterfrom
bump-helm-deps/support/hEtX

Conversation

@2i2c-token-generator-bot
Copy link
Copy Markdown
Contributor

@2i2c-token-generator-bot 2i2c-token-generator-bot Bot commented Dec 1, 2023

Upgrading most support components, except Grafana (due to some breaking changes)

…caler', 'cryptnono'] to versions ['25.8.0', '7.0.11', '4.8.3', '9.32.1', '0.3.0'], respectively
@2i2c-token-generator-bot 2i2c-token-generator-bot Bot requested a review from a team as a code owner December 1, 2023 00:10
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 1, 2023

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
gcp hhmi Yes Support helm chart has been modified No
gcp pangeo-hubs Yes Support helm chart has been modified No
kubeconfig utoronto Yes Support helm chart has been modified No
gcp meom-ige Yes Support helm chart has been modified No
aws victor Yes Support helm chart has been modified No
gcp 2i2c-uk Yes Support helm chart has been modified No
aws openscapes Yes Support helm chart has been modified No
aws nasa-esdis Yes Support helm chart has been modified No
aws nasa-cryo Yes Support helm chart has been modified No
aws jupyter-meets-the-earth Yes Support helm chart has been modified No
aws 2i2c-aws-us Yes Support helm chart has been modified No
gcp 2i2c Yes Support helm chart has been modified No
aws gridsst Yes Support helm chart has been modified No
gcp catalystproject-latam Yes Support helm chart has been modified No
aws nasa-veda Yes Support helm chart has been modified No
aws nasa-ghg Yes Support helm chart has been modified No
aws catalystproject-africa Yes Support helm chart has been modified No
gcp awi-ciroh Yes Support helm chart has been modified No
gcp callysto Yes Support helm chart has been modified No
aws earthscope Yes Support helm chart has been modified No
aws smithsonian Yes Support helm chart has been modified No
gcp leap Yes Support helm chart has been modified No
gcp cloudbank Yes Support helm chart has been modified No
gcp linked-earth Yes Support helm chart has been modified No
aws ubc-eoas Yes Support helm chart has been modified No
gcp qcl Yes Support helm chart has been modified No

Production deployments

No production hub upgrades will be triggered

Copy link
Copy Markdown
Member

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cryptnono has breaking changes so let's hold this for a bit

…yptnono'] to versions ['25.8.1', '4.8.4', '9.34.0', '0.3.1-0.dev.git.90.h35abda8'], respectively
…caler', 'cryptnono'] to versions ['25.8.2', '7.0.19', '4.9.0', '9.34.1', '0.3.1-0.dev.git.107.heb504bc'], respectively
yuvipanda added a commit to yuvipanda/pilot-hubs that referenced this pull request Jan 4, 2024
I've been upgrading cryptnono quite a bit over the last few months,
bringing in new detectors that have been quite effective on mybinder.org.
We automatically bump cryptnono on our clusters (2i2c-org#3482),
but recent progress have included some breaking changes to the helm
chart config.

This PR just brings in the new config changes, but does not change
behavior in any real way. No new detectors are enabled.

I've re-measured resource usage for the individual daemonset container
(rather than the initContainer) as that can now be set separately.
This probably requires us to redo some of the resource allocation
generated profiles, which I'll do once this is merged. However,
it is an overall reduction in daemonset requests, so deploying
this shouldn't result in any profile being undeployable.

Merging this should allow 2i2c-org#3482
to move forward as well.
@yuvipanda yuvipanda dismissed their stale review January 5, 2024 17:30

I fixed cryptnono

@yuvipanda
Copy link
Copy Markdown
Member

This can proceed now, as cryptnono's breaking changes were addressed by #3569

Comment thread helm-charts/support/Chart.yaml Outdated
@yuvipanda
Copy link
Copy Markdown
Member

I tried this out locally, but fails with:

Error: execution error at (support/charts/grafana/templates/deployment.yaml:36:28): Sensitive key 'auth.github.client_secret' should not be defined explicitly in values. Use variable expansion instead.

@yuvipanda
Copy link
Copy Markdown
Member

This is a little annoying because we do encrypt them already.

@yuvipanda
Copy link
Copy Markdown
Member

Comment thread helm-charts/support/Chart.yaml Outdated
@yuvipanda
Copy link
Copy Markdown
Member

It's important to keep this moving so our version bumps don't become too big, so am testing this out and will upgrade everything except grafana.

@yuvipanda
Copy link
Copy Markdown
Member

I've manually tested this on one cluster on each cloud provider, and it seems all good.

@yuvipanda yuvipanda merged commit 4e109bd into master Jan 17, 2024
@yuvipanda yuvipanda deleted the bump-helm-deps/support/hEtX branch January 17, 2024 00:39
@github-actions
Copy link
Copy Markdown
Contributor

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/7549375512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done 🎉

Development

Successfully merging this pull request may close these issues.

1 participant