LG-13312 Return an array from #requested_vtr_authn_context#100
Merged
LG-13312 Return an array from #requested_vtr_authn_context#100
#requested_vtr_authn_context#100Conversation
The `#requested_vtr_authn_context` method returns the vectors of trust that appeared in AuthnContextClassRef nodes in the SAML request. Service providers can send multiple vectors by adding additional AuthnContextClassRef nodes with vectors of trust in them. We initially managed this by selecting the first vector. However, we are interested in adding logic that selects an appropriate vector based on the user context. As a result we need to know all of the vectors that were passed in the SAML request. This commit modifies the `Request#requested_vtr_authn_context` so that it returns all of the vectors in the SAML request in an array.
jmhooper
requested review from
Sgtpluck,
jmax-gsa,
matthinz,
n1zyy,
solipet,
theabrad and
zachmargolis
jmhooper
changed the title
#requested_vtr_authn_context#requested_vtr_authn_context
jmhooper
changed the title
#requested_vtr_authn_context#requested_vtr_authn_context
zachmargolis
approved these changes
May 14, 2024
Sgtpluck
approved these changes
May 14, 2024
zachmargolis
approved these changes
May 14, 2024
matthinz
approved these changes
May 16, 2024
jmhooper
added a commit
to 18F/identity-idp
that referenced
this pull request
May 22, 2024
We added support for sending multiple vectors of trust using the OIDC interface in #10517. This commit adds the same feature to the SAML interace. To send multiple vectors using SAML partners can include multiple AuthnContextNodes with a vector in each. This was enabled in 18F/saml_idp#100. [skip changelog]
jmhooper
added a commit
to 18F/identity-idp
that referenced
this pull request
May 22, 2024
We added support for sending multiple vectors of trust using the OIDC interface in #10517. This commit adds the same feature to the SAML interace. To send multiple vectors using SAML partners can include multiple AuthnContextNodes with a vector in each. This was enabled in 18F/saml_idp#100. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Request#requested_vtr_authn_contextmethod returns the vectors of trust that appeared inAuthnContextClassRefnodes in the SAML request.Service providers can send multiple vectors by adding additional
AuthnContextClassRefnodes with vectors of trust in them. We initially managed this by selecting the first vector. However, we are interested in adding logic that selects an appropriate vector based on the user context. As a result we need to know all of the vectors that were passed in the SAML request.This commit modifies the
Request#requested_vtr_authn_contextso that it returns all of the vectors in the SAML request in an array.