LG-13313 Add multiple vector of trust support for SAML#10680
Merged
Conversation
jmhooper
commented
May 22, 2024
Contributor
Author
There was a problem hiding this comment.
I recommend hiding whitespace to review this file:
jmhooper
force-pushed
the
jmhooper-saml-user-aware-authn-context-resolver
branch
from
a5e36a7 to
bb46e1f
Compare
jmhooper
force-pushed
the
jmhooper-user-aware-authn-context-resolver
branch
from
a1f4cd5 to
3f7492e
Compare
jmhooper
force-pushed
the
jmhooper-saml-user-aware-authn-context-resolver
branch
from
bb46e1f to
088eff9
Compare
Base automatically changed from
jmhooper-user-aware-authn-context-resolver
to
main
May 22, 2024 17:45
We added support for sending multiple vectors of trust using the OIDC interface in #10517. This commit adds the same feature to the SAML interace. To send multiple vectors using SAML partners can include multiple AuthnContextNodes with a vector in each. This was enabled in 18F/saml_idp#100. [skip changelog]
jmhooper
force-pushed
the
jmhooper-saml-user-aware-authn-context-resolver
branch
from
607d1c1 to
5291f41
Compare
jmhooper
changed the title
matthinz
approved these changes
May 22, 2024
| return @parsed_vectors_of_trust if defined?(@parsed_vectors_of_trust) | ||
|
|
||
| @parsed_vectors_of_trust = begin | ||
| if vtr.is_a?(Array) && !vtr.empty? |
Contributor
There was a problem hiding this comment.
The Array class check is confusing to me, what happens if it is not an array?
I'd expect something like Array(vtr).map { ... } which would seamlessly handle arrays and single items
Contributor
Author
There was a problem hiding this comment.
I merged before I saw this comment. I think this could be cleared up with a simple #blank? check. We want to fall back to ACR values if it is an empty array or nil. I'll follow up in a new PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added support for sending multiple vectors of trust using the OIDC interface in #10517. This commit adds the same feature to the SAML interace.
To send multiple vectors using SAML partners can include multiple AuthnContextNodes with a vector in each. This was enabled in 18F/saml_idp#100.