Per-country sender ID (LG-5060)

[zachmargolis]

I chose to add country_code as a param instead of adding a dependency on Phonelib to parse the numbers inside the gem, which added a lot of noise to the diff.

We're planning to move this back inside the IDP, so maybe it would't be that bad to depend on Phonelib? Open to feedback here,

[orenyk]

LGTM

[aduth]

We're planning to move this back inside the IDP, so maybe it would't be that bad to depend on Phonelib? Open to feedback here,

Seems like a compelling argument to use it, but don't feel too strongly one way or the other 🤷

[zachmargolis]

We're planning to move this back inside the IDP, so maybe it would't be that bad to depend on Phonelib? Open to feedback here,

Seems like a compelling argument to use it, but don't feel too strongly one way or the other 🤷

My other thought, was we can save a few Phonelib.parse with passing in the country and not having to parse again... and small changes to these more heavily trafficked endpoints have added up to big time savings in the past 18F/identity-idp#4330 ➡️ prev example 📉 ... gonna keep this for now