Merged
Conversation
Contributor
zachmargolis
commented
Sep 2, 2021
zachmargolis
commented
- Stop sending sender ID to countries that do not require it (by changing configs and update Telephony gem, see Per-country sender ID (LG-5060) identity-telephony#51)
- Update parsing of Pinpoint docs to handle India better (it does not require a Sender ID the way the other ones do)
- send country_code to Telephony gem
- Also remove India override
zachmargolis
requested review from
aduth,
mitchellhenke,
orenyk and
pauldoomgov
orenyk
approved these changes
Sep 3, 2021
| @@ -1,3 +1,5 @@ | |||
| require 'pinpoint_supported_countries' | |||
Contributor
There was a problem hiding this comment.
comment: omg I did not know this file existed - mind blown.
aduth
approved these changes
Sep 3, 2021
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
- I'm not used to this and not a fan of additional rails monkeypatches but whatever
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.