Conversation
Contributor
Author
|
Other ideas:
|
Contributor
Author
|
It probably makes sense to release the next major version in tandem with USWDS v3, which is slated for release next month. |
8ff1c7c to
16c0c78
Compare
Contributor
Author
I still like many of these ideas, but we can save them for a future major release. |
Contributor
Author
|
@zachmargolis I think I'd like to include these changes in the upcoming release. Could I tap you for a review? |
(1) the width does not match the width of a paragraph in prose anyways (2) there's already a utility to achieve this effect
2d0e940 to
9a579f0
Compare
Contributor
Author
|
Visual regression failure is from the removal of the "Limiting Alert Width" documentation section, which is an expected breaking change. |
aduth
added a commit
that referenced
this pull request
Apr 3, 2023
This was referenced Apr 28, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a staging area for breaking changes we'd like to implement in a future major version release.
Currently, it includes: