Skip to content

Improve reliability of WebauthnSetupForm spec #9963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 3 commits into from
Jan 24, 2024
Merged

Improve reliability of WebauthnSetupForm spec #9963

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
600a3f3
Improve reliability of WebauthnSetupForm spec
aduth Jan 24, 2024
7f0603f
Assign transports for consistency
aduth Jan 24, 2024
041721f
Use correct value format
aduth Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 19 additions & 31 deletions spec/forms/webauthn_setup_form_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,10 @@
end
end
context 'webauthn_platform' do
let(:params) do
super().merge(platform_authenticator: true, transports: 'internal,hybrid')
end

context 'with one platform authenticator with the same name' do
let(:user) do
user = create(:user)
Expand All @@ -257,12 +261,7 @@
)
user
end
let(:params) do
super().merge(
platform_authenticator: true,
transports: 'internal,hybrid',
)
end

it 'adds a new platform device with the same existing name and appends a (1)' do
result = subject.submit(protocol, params)
expect(result.extra[:multi_factor_auth_method]).to eq 'webauthn_platform'
Expand All @@ -276,37 +275,26 @@
end

context 'with two existing platform authenticators one with the same name' do
let(:user) do
user = create(:user)
user.webauthn_configurations << create(
:webauthn_configuration,
name: device_name,
platform_authenticator: true,
transports: ['internal', 'hybrid'],
)
user.webauthn_configurations << create(
:webauthn_configuration,
name: device_name,
platform_authenticator: true,
transports: ['internal', 'hybrid'],
)
user
end
let(:params) do
super().merge(
platform_authenticator: true,
transports: 'internal,hybrid',
let!(:user) do
create(
:user,
webauthn_configurations: create_list(
:webauthn_configuration,
2,
Copy link
Copy Markdown
Contributor

@kevinsmaster5 kevinsmaster5 Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm understanding correctly - this creates the 2 configurations at the same time rather than how they were being created before? Using create_list.

Copy link
Copy Markdown
Contributor Author

@aduth aduth Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, a little trick I learned recently.

name: device_name,
platform_authenticator: true,
transports: ['internal', 'hybrid'],
),
)
end

it 'adds a second new platform device with the same existing name and appends a (2)' do
result = subject.submit(protocol, params)
expect(result.extra[:multi_factor_auth_method]).to eq 'webauthn_platform'

expect(result.success?).to eq(true)
expect(user.webauthn_configurations.platform_authenticators.count).to eq(3)
expect(
user.webauthn_configurations.platform_authenticators[2].name,
).
expect(user.webauthn_configurations.platform_authenticators.last.name).
to eq("#{device_name} (2)")
expect(result.to_h[:success]).to eq(true)
end
end
end
Expand Down