Improve reliability of WebauthnSetupForm spec#9963
Merged
Conversation
changelog: Internal, Automated Testing, Improve reliability of tests
| :user, | ||
| webauthn_configurations: create_list( | ||
| :webauthn_configuration, | ||
| 2, |
Contributor
There was a problem hiding this comment.
If I'm understanding correctly - this creates the 2 configurations at the same time rather than how they were being created before? Using create_list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Revises
webauthn_setup_form_spec.rbin hopes of reducing some test flakiness.Example: https://gsa-tts.slack.com/archives/C0NGESUN5/p1706048041505969
The suspected cause is that
let(:user)is lazily evaluated after the form is already submitted, which is likely not the intent of the test setup. Eagerly assigninglet!(:user)with existing authenticators should hopefully produce a more reliable result.📜 Testing Plan
Verify the test passes: