Skip to content

Update flash message styles #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monfresh merged 1 commit into from
Jan 26, 2017
Merged

Update flash message styles #995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/assets/images/alert/error.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions app/assets/images/alert/success.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions app/assets/images/alert/warning.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
15 changes: 7 additions & 8 deletions app/assets/stylesheets/components/_alert.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ $ico-offset: -10px;
background-color: $blue-light;
border-radius: $space-1;
color: #5b616a;
font-size: $sm-h6;
font-weight: $bold-font-weight;
font-size: 1rem;
line-height: $line-height-2;
margin-bottom: $space-4;
padding: $space-2 1.5rem;
Expand All @@ -26,22 +25,22 @@ $ico-offset: -10px;

.alert-notice,
.alert-success {
background-color: #f0faed;
background-color: #ebfcef;
Copy link
Copy Markdown
Contributor

@jessieay jessieay Jan 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these be named?

Copy link
Copy Markdown
Contributor Author

@hursey013 hursey013 Jan 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These colors aren't being used elsewhere at this point so I think it's fine that they are one-offs in this case. I did talk with Ryan yesterday and we tried to consolidate all of the colors into one color palette and I will likely do some naming/renaming in a future PR for that.


&::before { background-image: url(image-path('alert/ico-check.svg')); }
&::before { background-image: url(image-path('alert/success.svg')); }
}
Copy link
Copy Markdown
Contributor

@jessieay jessieay Jan 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this image now unused / removable?

Copy link
Copy Markdown
Contributor Author

@hursey013 hursey013 Jan 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it in there for now because it is being used by the progress bar, but we can remove it after that is gone. Again, I will likely do an audit of all the various icons in the future to clean up an unnecessary images.


.alert-error,
.alert-alert {
background-color: #fff0f2;
background-color: #fff0f3;

&::before { background-image: url(image-path('alert/ico-exclamation.svg')); }
&::before { background-image: url(image-path('alert/error.svg')); }
}

.alert-warning {
background-color: #fff4db;
background-color: #fffccf;

&::before { background-image: url(image-path('alert/ico-warning.svg')); }
&::before { background-image: url(image-path('alert/warning.svg')); }
}

.alert-no-icon::before { content: none; }