Conversation
**Why**: To match latest visual designs
hursey013
force-pushed
the
bh-update-flash-msgs
branch
from
4fa502e to
30c5dc5
Compare
jessieay
reviewed
Jan 26, 2017
| .alert-notice, | ||
| .alert-success { | ||
| background-color: #f0faed; | ||
| background-color: #ebfcef; |
Contributor
Author
There was a problem hiding this comment.
These colors aren't being used elsewhere at this point so I think it's fine that they are one-offs in this case. I did talk with Ryan yesterday and we tried to consolidate all of the colors into one color palette and I will likely do some naming/renaming in a future PR for that.
| background-color: #f0faed; | ||
| background-color: #ebfcef; | ||
|
|
||
| &::before { background-image: url(image-path('alert/ico-check.svg')); } |
Contributor
There was a problem hiding this comment.
is this image now unused / removable?
Contributor
Author
There was a problem hiding this comment.
I left it in there for now because it is being used by the progress bar, but we can remove it after that is gone. Again, I will likely do an audit of all the various icons in the future to clean up an unnecessary images.
amoose
pushed a commit
that referenced
this pull request
Mar 7, 2017
**Why**: To match latest visual designs
amoose
pushed a commit
that referenced
this pull request
Mar 8, 2017
**Why**: To match latest visual designs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: To match latest visual designs
