Skip to content

Add Puma configuration#9848

Merged
mitchellhenke merged 2 commits intomainfrom
mitchellhenke/puma-config
Jan 4, 2024
Merged

Add Puma configuration#9848
mitchellhenke merged 2 commits intomainfrom
mitchellhenke/puma-config

Conversation

@mitchellhenke
Copy link
Contributor

🛠 Summary of changes

We use puma in local development and review applications, but do not include a configuration for it. This change adds a slightly modified version of the puma config that Rails generates in new applications.

@mitchellhenke mitchellhenke requested a review from aduth January 3, 2024 22:35
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/puma-config branch from fc5d8e6 to 65b8c71 Compare January 3, 2024 22:37
changelog: Internal, Configuration, Add Puma configuration
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/puma-config branch from 65b8c71 to 5440eb1 Compare January 3, 2024 23:03
@aduth
Copy link
Contributor

aduth commented Jan 4, 2024

Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this does seem to alleviate the hanging requests 👍

I'm a little concerned that multithreaded isn't working though, if it implies some incompatibility of our code or other dependencies. I found a similar StackOverflow question which is almost identical to our scenario, including the lock debug result, but there doesn't seem to be an answer there. Maybe it's a Puma issue? In any case, the DebugLocks middleware was new to me and could be useful.

@mitchellhenke
Copy link
Contributor Author

I can confirm that this does seem to alleviate the hanging requests 👍

I'm a little concerned that multithreaded isn't working though, if it implies some incompatibility of our code or other dependencies. I found a similar StackOverflow question which is almost identical to our scenario, including the lock debug result, but there doesn't seem to be an answer there. Maybe it's a Puma issue? In any case, the DebugLocks middleware was new to me and could be useful.

Yep, there is work to do on multi-threading. It appears to be something with reloading.

@mitchellhenke mitchellhenke merged commit cb71bcb into main Jan 4, 2024
@mitchellhenke mitchellhenke deleted the mitchellhenke/puma-config branch January 4, 2024 20:49
@amirbey amirbey mentioned this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants