Skip to content

Update puma config and add binstubs#739

Merged
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/update-puma-config
Feb 21, 2024
Merged

Update puma config and add binstubs#739
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/update-puma-config

Conversation

@mitchellhenke
Copy link

@mitchellhenke mitchellhenke commented Feb 20, 2024

Relevant Ticket or Conversation:

Slack thread

Description of Changes:

This PR modifies the Puma config to be more configurable for our potential production use case and changes the defaults to use one thread per process. The application is not confirmed to be thread-safe, and having multiple threads may cause deadlocking or other issues. It is modeled after the changes in the IDP here.

I've also added a few binstubs that would also be useful in production.

PR Checklist:

  1. Have you linted and tested your code locally prior to submission?
  2. Have you tagged the appropriate dev(s) for review?
  3. Have you linked to any relevant tickets or conversations?

PR Review Standards:

  • Consider using Conventional Comments to ensure that your feedback is clear and actionable.
  • Ideally, PRs should be reviewed by at least 2 team members.
  • All PRs must be approved before being merged.

@mitchellhenke mitchellhenke requested a review from a team as a code owner February 20, 2024 17:54
@mitchellhenke mitchellhenke merged commit 52efcfc into main Feb 21, 2024
@mitchellhenke mitchellhenke deleted the mitchellhenke/update-puma-config branch February 21, 2024 15:50
@mitchellhenke mitchellhenke mentioned this pull request Feb 27, 2024
3 tasks
@mitchellhenke mitchellhenke restored the mitchellhenke/update-puma-config branch May 14, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants