Conversation
…uest This commit adds an argument to the `ServiceProviderRequest` object in anticipation for its use in a later change. This is to allow compatibility between old and new code. [skip changelog]
solipet
approved these changes
Dec 19, 2023
soniaconnolly
approved these changes
Dec 19, 2023
| aal: nil, | ||
| requested_attributes: [], | ||
| biometric_comparison_required: false | ||
| biometric_comparison_required: false # rubocop:disable Lint/UnusedMethodArgument |
Contributor
There was a problem hiding this comment.
for my understanding, this is the one line that is not completely reverted?
Contributor
Author
There was a problem hiding this comment.
That is correct. I kept the revert changes in the first commit and then added this in a second.
jmhooper
added a commit
that referenced
this pull request
Dec 19, 2023
…ired in the SP session (#9759)" (#9804)" This reverts commit 558ebd6. The reverted commit here was reverting the changes in #9759. That change had issues with compatibility which were addressed in the changes in the reverted commit and deployed. The deployment of those changes makes this commit safe to merge. [skip changelog]
jmhooper
added a commit
that referenced
this pull request
Dec 19, 2023
…ired in the SP session (#9759)" (#9804)" (#9806) This reverts commit 558ebd6. The reverted commit here was reverting the changes in #9759. That change had issues with compatibility which were addressed in the changes in the reverted commit and deployed. The deployment of those changes makes this commit safe to merge. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 6fee3a0 because there were issues in the compatibility of the new service provider request model with old hosts.
This commit reverts the problematic change and adds a default arg to ensure compatibility. The commit reverted here can be un-reverted once the change to add the default value has shipped.