Conversation
…ession We have not clearly defined how we want service providers to request a biometric comparison. This commit adds a query parameter to the OIDC authorization URL to specify that a biometric is required. This is temporary and intended to enable us to test the selfie / in-person requirement end-to-end before the API for requesting this functionality is fully defined. This commit stores the attribute in the SP session. It does not make any changes to functionality based on the attribute or apply any changes to the SAML API. The corresponding change on the sample app is here: 18F/identity-oidc-sinatra#149 changelog: Internal, Biometric comparison, A parameter was added to test the selfie workflow end-to-end
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
aduth
reviewed
Dec 14, 2023
solipet
approved these changes
Dec 14, 2023
Contributor
solipet
left a comment
solipet
left a comment
There was a problem hiding this comment.
Confirmed the flag is set in the session when requested from the sample app
jmhooper
deleted the
jmhooper-store-biometric-requirement-in-sp-session
branch
Merged
jmhooper
added a commit
that referenced
this pull request
Dec 19, 2023
…ired in the SP session (#9759)" (#9804)" This reverts commit 558ebd6. The reverted commit here was reverting the changes in #9759. That change had issues with compatibility which were addressed in the changes in the reverted commit and deployed. The deployment of those changes makes this commit safe to merge. [skip changelog]
jmhooper
added a commit
that referenced
this pull request
Dec 19, 2023
…ired in the SP session (#9759)" (#9804)" (#9806) This reverts commit 558ebd6. The reverted commit here was reverting the changes in #9759. That change had issues with compatibility which were addressed in the changes in the reverted commit and deployed. The deployment of those changes makes this commit safe to merge. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have not clearly defined how we want service providers to request a biometric comparison. This commit adds a query parameter to the OIDC authorization URL to specify that a biometric is required. This is temporary and intended to enable us to test the selfie / in-person requirement end-to-end before the API for requesting this functionality is fully defined.
This commit stores the attribute in the SP session. It does not make any changes to functionality based on the attribute or apply any changes to the SAML API.
The corresponding change on the sample app is here: 18F/identity-oidc-sinatra#149