Rescue errors in Agencies and SPs report#9775
Merged
zachmargolis merged 2 commits intomainfrom Dec 15, 2023
Merged
Conversation
- In #9744, we added more correct queries that took much longer. Even though we added the correct transaction_with_timeout wrapper, and even though the queries can succeed, the report still failed in prod. - Adding this rescue allows the report to complete and send partial results still changelog: Internal, Reporting, Add error handling for long-running queries
zachmargolis
commented
Dec 15, 2023
| map(&:agency). | ||
| uniq | ||
| end | ||
| @active_agencies ||= Agreements::PartnerAccountStatus.find_by(name: 'active'). |
Contributor
Author
There was a problem hiding this comment.
this change should be a no-op but I wanted to clean it up while I was already here
ThatSpaceGuy
approved these changes
Dec 15, 2023
Contributor
ThatSpaceGuy
left a comment
ThatSpaceGuy
left a comment
There was a problem hiding this comment.
Looks good - thank you!
zachmargolis
deleted the
margolis-rescue-errors-in-agencies-and-sps-report
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Handle query timeouts in Agencies and SPs report
In Update apps/agencies report to exclude internal apps (LG-11800) #9744, we added more correct queries that took much longer. Even though we added the correct
transaction_with_timeoutwrapper, and even though the queries can succeed, the report still failed in prod. error linkAdding this rescue allows the report to complete and send partial results still