Update apps/agencies report to exclude internal apps (LG-11800)#9744
Merged
zachmargolis merged 7 commits intomainfrom Dec 13, 2023
Merged
Update apps/agencies report to exclude internal apps (LG-11800)#9744zachmargolis merged 7 commits intomainfrom
zachmargolis merged 7 commits intomainfrom
Conversation
changelog: Internal, Reporting, Update monthly reporting on apps & agencies to exclude internal apps
Sgtpluck
approved these changes
Dec 12, 2023
Contributor
Sgtpluck
left a comment
Sgtpluck
left a comment
There was a problem hiding this comment.
lil suggestion but LGTM
Contributor
Author
|
@18F/identity-agnes I took a second look at my notes from the investigation on this and realized I neede to redo some more queries, so I pushed changes in f6b93cb, PTAL! I ran this in prod and posted the results in Slack |
Merged
zachmargolis
added a commit
that referenced
this pull request
Dec 15, 2023
- In #9744, we added more correct queries that took much longer. Even though we added the correct transaction_with_timeout wrapper, and even though the queries can succeed, the report still failed in prod. - Adding this rescue allows the report to complete and send partial results still changelog: Internal, Reporting, Add error handling for long-running queries
zachmargolis
added a commit
that referenced
this pull request
Dec 15, 2023
* Handle query timeouts in Agencies and SPs report - In #9744, we added more correct queries that took much longer. Even though we added the correct transaction_with_timeout wrapper, and even though the queries can succeed, the report still failed in prod. - Adding this rescue allows the report to complete and send partial results still * Remove extra begin...end syntax changelog: Internal, Reporting, Add error handling for long-running queries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11800
🛠 Summary of changes
We were reporting on 5 apps that are internal (OIDC example, etc), but we should be excluding those for reporting. Major kudos to @Sgtpluck for finding that all the apps we needed to exclude conveniently had
iaa: 'LGINTERNAL'on them.