Skip to content

Address Controller Update Analytics #9774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gina-yamada merged 4 commits into from
Dec 18, 2023
Merged

Address Controller Update Analytics #9774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2dd2f42
Fix in person address controller analytics
soniaconnolly Dec 15, 2023
741b662
Remove explicit step_count from analytics_events
soniaconnolly Dec 15, 2023
8ac8a7a
changelog: Internal, In-person proofing, Updated analytic args for no…
gina-yamada Dec 15, 2023
5601123
Merge remote-tracking branch 'origin/main' into yamada/address-contro…
soniaconnolly Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/controllers/idv/in_person/address_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,9 @@ def analytics_arguments
step: 'address',
analytics_id: 'In Person Proofing',
irs_reproofing: irs_reproofing?,
**opt_in_analytics_properties,
}
}.merge(ab_test_analytics_buckets).
merge(extra_analytics_properties).
merge(opt_in_analytics_properties)
end

def redirect_to_next_page
Expand Down
18 changes: 0 additions & 18 deletions app/services/analytics_events.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1595,15 +1595,13 @@ def idv_in_person_prepare_visited(flow_path:, opted_in_to_in_person_proofing:, *

# @param [String] flow_path
# @param [String] step
# @param [Integer] step_count
# @param [String] analytics_id
# @param [Boolean] irs_reproofing
# @param [Boolean] opted_in_to_in_person_proofing User opted into in person proofing
# address page visited
def idv_in_person_proofing_address_visited(
flow_path: nil,
step: nil,
step_count: nil,
analytics_id: nil,
irs_reproofing: nil,
opted_in_to_in_person_proofing: nil,
Expand All @@ -1613,7 +1611,6 @@ def idv_in_person_proofing_address_visited(
'IdV: in person proofing address visited',
flow_path: flow_path,
step: step,
step_count: step_count,
analytics_id: analytics_id,
irs_reproofing: irs_reproofing,
opted_in_to_in_person_proofing: opted_in_to_in_person_proofing,
Expand All @@ -1623,7 +1620,6 @@ def idv_in_person_proofing_address_visited(

# @param [String] flow_path
# @param [String] step
# @param [Integer] step_count
# @param [String] analytics_id
# @param [Boolean] irs_reproofing
# @param [Boolean] success
Expand All @@ -1633,7 +1629,6 @@ def idv_in_person_proofing_address_visited(
def idv_in_person_proofing_cancel_update_address(
flow_path: nil,
step: nil,
step_count: nil,
analytics_id: nil,
irs_reproofing: nil,
success: nil,
Expand All @@ -1645,7 +1640,6 @@ def idv_in_person_proofing_cancel_update_address(
'IdV: in person proofing cancel_update_address submitted',
flow_path: flow_path,
step: step,
step_count: step_count,
analytics_id: analytics_id,
irs_reproofing: irs_reproofing,
success: success,
Expand All @@ -1657,7 +1651,6 @@ def idv_in_person_proofing_cancel_update_address(

# @param [String] flow_path
# @param [String] step
# @param [Integer] step_count
# @param [String] analytics_id
# @param [Boolean] irs_reproofing
# @param [Boolean] success
Expand All @@ -1667,7 +1660,6 @@ def idv_in_person_proofing_cancel_update_address(
def idv_in_person_proofing_cancel_update_state_id(
flow_path: nil,
step: nil,
step_count: nil,
analytics_id: nil,
irs_reproofing: nil,
success: nil,
Expand All @@ -1679,7 +1671,6 @@ def idv_in_person_proofing_cancel_update_state_id(
'IdV: in person proofing cancel_update_state_id submitted',
flow_path: flow_path,
step: step,
step_count: step_count,
analytics_id: analytics_id,
irs_reproofing: irs_reproofing,
success: success,
Expand Down Expand Up @@ -1760,7 +1751,6 @@ def idv_in_person_proofing_nontransliterable_characters_submitted(

# @param [String] flow_path
# @param [String] step
# @param [Integer] step_count
# @param [String] analytics_id
# @param [Boolean] irs_reproofing
# @param [Boolean] success
Expand All @@ -1770,7 +1760,6 @@ def idv_in_person_proofing_nontransliterable_characters_submitted(
def idv_in_person_proofing_redo_state_id_submitted(
flow_path: nil,
step: nil,
step_count: nil,
analytics_id: nil,
irs_reproofing: nil,
success: nil,
Expand All @@ -1782,7 +1771,6 @@ def idv_in_person_proofing_redo_state_id_submitted(
'IdV: in person proofing redo_state_id submitted',
flow_path: flow_path,
step: step,
step_count: step_count,
analytics_id: analytics_id,
irs_reproofing: irs_reproofing,
success: success,
Expand All @@ -1798,7 +1786,6 @@ def idv_in_person_proofing_residential_address_submitted(**extra)

# @param [String] flow_path
# @param [String] step
# @param [Integer] step_count
# @param [String] analytics_id
# @param [Boolean] irs_reproofing
# @param [Boolean] success
Expand All @@ -1809,7 +1796,6 @@ def idv_in_person_proofing_residential_address_submitted(**extra)
def idv_in_person_proofing_state_id_submitted(
flow_path: nil,
step: nil,
step_count: nil,
analytics_id: nil,
irs_reproofing: nil,
success: nil,
Expand All @@ -1822,7 +1808,6 @@ def idv_in_person_proofing_state_id_submitted(
'IdV: in person proofing state_id submitted',
flow_path: flow_path,
step: step,
step_count: step_count,
analytics_id: analytics_id,
irs_reproofing: irs_reproofing,
success: success,
Expand All @@ -1835,15 +1820,13 @@ def idv_in_person_proofing_state_id_submitted(

# @param [String] flow_path
# @param [String] step
# @param [Integer] step_count
# @param [String] analytics_id
# @param [Boolean] irs_reproofing
# @param [Boolean] opted_in_to_in_person_proofing User opted into in person proofing
# State id page visited
def idv_in_person_proofing_state_id_visited(
flow_path: nil,
step: nil,
step_count: nil,
analytics_id: nil,
irs_reproofing: nil,
opted_in_to_in_person_proofing: nil,
Expand All @@ -1853,7 +1836,6 @@ def idv_in_person_proofing_state_id_visited(
'IdV: in person proofing state_id visited',
flow_path: flow_path,
step: step,
step_count: step_count,
analytics_id: analytics_id,
irs_reproofing: irs_reproofing,
opted_in_to_in_person_proofing: opted_in_to_in_person_proofing,
Expand Down
19 changes: 18 additions & 1 deletion spec/controllers/idv/in_person/address_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,12 @@
irs_reproofing: false,
opted_in_to_in_person_proofing: nil,
step: 'address',
step_count: nil,
lexisnexis_instant_verify_workflow_ab_test_bucket: :default,
pii_like_keypaths: [[:same_address_as_id],
[:proofing_results, :context, :stages, :state_id,
:state_id_jurisdiction]],
same_address_as_id: false,
skip_hybrid_handoff: nil,
}
end

Expand Down Expand Up @@ -148,6 +153,12 @@
flow_path: 'standard',
irs_reproofing: false,
step: 'address',
lexisnexis_instant_verify_workflow_ab_test_bucket: :default,
pii_like_keypaths: [[:same_address_as_id],
[:proofing_results, :context, :stages, :state_id,
:state_id_jurisdiction]],
same_address_as_id: false,
skip_hybrid_handoff: nil,
}
end

Expand Down Expand Up @@ -226,6 +237,12 @@
flow_path: 'standard',
irs_reproofing: false,
step: 'address',
lexisnexis_instant_verify_workflow_ab_test_bucket: :default,
pii_like_keypaths: [[:same_address_as_id],
[:proofing_results, :context, :stages, :state_id,
:state_id_jurisdiction]],
same_address_as_id: false,
skip_hybrid_handoff: nil,
}
end

Expand Down