Skip to content

Address Controller Update Analytics#9774

Merged
gina-yamada merged 4 commits intomainfrom
yamada/address-controller-update-analytics
Dec 18, 2023
Merged

Address Controller Update Analytics#9774
gina-yamada merged 4 commits intomainfrom
yamada/address-controller-update-analytics

Conversation

@gina-yamada
Copy link
Contributor

@gina-yamada gina-yamada commented Dec 15, 2023

🛠 Summary of changes

  • Add ab_test_analytics_buckets to analytics arguments for new non-FSM Address Controller
  • Add extra_analytics_properties to analytics arguments for new non-FSM Address Controller
  • Remove explicit step_count arg from analytic events (in-person address, state ID). The FSM can still pass in step_count through **extra but now it is not required.

📜 Testing Plan

  • Step 1: Set in_person_residential_address_controller_enabled to false
  • Step 2: Run through IPP proofing to fail proofing. Pick I have a different address than my state id. Continue through flow to Verify Info and confirm that the residential address is correct (and can be edited) and submitted. Get a barcode to show nothing has been affected.
  • Step 3: Set in_person_residential_address_controller_enabled to true
  • Step 4: Repeat step 2.

soniaconnolly and others added 3 commits December 15, 2023 09:11
Co-authored-by: Gina Yamada <gina.yamada@gsa.gov>
step_count can still be passed in via **extra. It is left over from the
Flow State Machine and is in the process of being removed. No one is using the data.
@gina-yamada gina-yamada marked this pull request as ready for review December 15, 2023 17:40
@gina-yamada
Copy link
Contributor Author

gina-yamada commented Dec 15, 2023

@svalexander There are a few more items to add to analytics for the new non-FSM address controller.

You can see these args are also added in the ssn_controller analytic list.app/controllers/idv/in_person/ssn_controller.rb. Sonia spotted this! 🎉 We should do the same for the new address controller.

Screenshot 2023-12-15 at 11 06 06 AM

Copy link
Contributor

@svalexander svalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gina-yamada gina-yamada merged commit ac24b24 into main Dec 18, 2023
@gina-yamada gina-yamada deleted the yamada/address-controller-update-analytics branch December 18, 2023 20:58
@jmdembe jmdembe mentioned this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants