LG-11634: remove phone question and logging from backend

app/controllers/concerns/idv/ab_test_analytics_concern.rb

@@ -1,17 +1,14 @@
 module Idv
   module AbTestAnalyticsConcern
     include AcuantConcern
-    include Idv::PhoneQuestionAbTestConcern
 
     def ab_test_analytics_buckets
       buckets = {}
       if defined?(idv_session)
         buckets[:skip_hybrid_handoff] = idv_session&.skip_hybrid_handoff
-        buckets[:phone_with_camera] = idv_session&.phone_with_camera
       end
 
-      buckets.merge(acuant_sdk_ab_test_analytics_args).
-        merge(phone_question_ab_test_analytics_bucket)
+      buckets.merge(acuant_sdk_ab_test_analytics_args)
     end
   end
 end

app/controllers/idv/agreement_controller.rb

@@ -47,7 +47,7 @@ def self.step_info
       Idv::StepInfo.new(
         key: :agreement,
         controller: self,
-        next_steps: [:hybrid_handoff, :document_capture, :phone_question, :how_to_verify],
+        next_steps: [:hybrid_handoff, :document_capture, :how_to_verify],
         preconditions: ->(idv_session:, user:) { idv_session.welcome_visited },
         undo_step: ->(idv_session:, user:) do
           idv_session.idv_consent_given = nil

app/controllers/idv/document_capture_controller.rb

@@ -5,7 +5,6 @@ class DocumentCaptureController < ApplicationController
     include DocumentCaptureConcern
     include IdvStepConcern
     include StepIndicatorConcern
-    include PhoneQuestionAbTestConcern
 
     before_action :confirm_not_rate_limited, except: [:update]
     before_action :confirm_step_allowed
@@ -47,11 +46,9 @@ def extra_view_variables
         flow_path: 'standard',
         sp_name: decorated_sp_session.sp_name,
         failure_to_proof_url: return_to_sp_failure_to_proof_url(step: 'document_capture'),
-        phone_with_camera: idv_session.phone_with_camera,
         skip_doc_auth: idv_session.skip_doc_auth,
       }.merge(
         acuant_sdk_upgrade_a_b_testing_variables,
-        phone_question_ab_test_analytics_bucket,
       )
     end
 

app/controllers/idv/hybrid_handoff_controller.rb

@@ -4,12 +4,10 @@ class HybridHandoffController < ApplicationController
     include ActionView::Helpers::DateHelper
     include IdvStepConcern
     include StepIndicatorConcern
-    include PhoneQuestionAbTestConcern
 
     before_action :confirm_not_rate_limited
     before_action :confirm_step_allowed
     before_action :confirm_hybrid_handoff_needed, only: :show
-    before_action :maybe_redirect_for_phone_question_ab_test, only: :show
 
     def show
       analytics.idv_doc_auth_hybrid_handoff_visited(**analytics_arguments)
@@ -19,7 +17,6 @@ def show
         true
       )
 
-      @phone_question_ab_test_bucket = phone_question_ab_test_bucket
       render :show, locals: extra_view_variables
     end
 

app/controllers/idv/hybrid_mobile/document_capture_controller.rb

@@ -4,7 +4,6 @@ class DocumentCaptureController < ApplicationController
       include Idv::AvailabilityConcern
       include DocumentCaptureConcern
       include HybridMobileConcern
-      include PhoneQuestionAbTestConcern
 
       before_action :check_valid_document_capture_session
       before_action :override_csp_to_allow_acuant
@@ -44,8 +43,7 @@ def extra_view_variables
           failure_to_proof_url: return_to_sp_failure_to_proof_url(step: 'document_capture'),
         }.merge(
           acuant_sdk_upgrade_a_b_testing_variables,
-          phone_question_ab_test_analytics_bucket,
-        ).merge(phone_with_camera)
+        )
       end
 
       private
@@ -58,7 +56,7 @@ def analytics_arguments
           irs_reproofing: irs_reproofing?,
         }.merge(
           ab_test_analytics_buckets,
-        ).merge(phone_with_camera)
+        )
       end
 
       def handle_stored_result
@@ -85,10 +83,6 @@ def redo_document_capture_pending?
 
         document_capture_session.requested_at > stored_result.captured_at
       end
-
-      def phone_with_camera
-        { phone_with_camera: phone_question_ab_test_bucket == :show_phone_question ? true : nil }
-      end
     end
   end
 end

app/controllers/idv/link_sent_controller.rb

@@ -4,7 +4,6 @@ class LinkSentController < ApplicationController
     include DocumentCaptureConcern
     include IdvStepConcern
     include StepIndicatorConcern
-    include PhoneQuestionAbTestConcern
 
     before_action :confirm_not_rate_limited
     before_action :confirm_step_allowed
@@ -34,10 +33,7 @@ def update
     end
 
     def extra_view_variables
-      { phone: idv_session.phone_for_mobile_flow }.merge(
-        phone_question_ab_test_analytics_bucket,
-        phone_with_camera: idv_session.phone_with_camera,
-      )
+      { phone: idv_session.phone_for_mobile_flow }
     end
 
     def self.step_info

app/forms/idv/api_image_upload_form.rb

@@ -150,12 +150,10 @@ def extra_attributes
         user_id: user_uuid,
         pii_like_keypaths: DocPiiForm.pii_like_keypaths,
         flow_path: params[:flow_path],
-        phone_with_camera: phone_with_camera,
       }
 
       @extra_attributes[:front_image_fingerprint] = front_image_fingerprint
       @extra_attributes[:back_image_fingerprint] = back_image_fingerprint
-      @extra_attributes.merge!(phone_question_ab_test_analytics_bucket)
       @extra_attributes
     end
 
@@ -284,8 +282,7 @@ def doc_auth_client
         vendor_discriminator: document_capture_session_uuid,
         warn_notifier: proc do |attrs|
           analytics&.doc_auth_warning(
-            **attrs.
-                        merge(phone_question_ab_test_analytics_bucket),
+            **attrs,
           )
         end,
       )
@@ -318,11 +315,9 @@ def update_analytics(client_response:, vendor_request_time_in_ms:)
           client_image_metrics: image_metadata,
           async: false,
           flow_path: params[:flow_path],
-          phone_with_camera: phone_with_camera,
           vendor_request_time_in_ms: vendor_request_time_in_ms,
         ).except(:classification_info).
-        merge(acuant_sdk_upgrade_ab_test_data).
-        merge(phone_question_ab_test_analytics_bucket),
+        merge(acuant_sdk_upgrade_ab_test_data),
       )
     end
 
@@ -353,13 +348,6 @@ def acuant_sdk_upgrade_ab_test_data
       }
     end
 
-    def phone_question_ab_test_analytics_bucket
-      {
-        phone_question_ab_test_bucket:
-          AbTests::IDV_PHONE_QUESTION.bucket(user_uuid),
-      }
-    end
-
     def acuant_sdk_capture?
       image_metadata.dig(:front, :source) == Idp::Constants::Vendors::ACUANT &&
         image_metadata.dig(:back, :source) == Idp::Constants::Vendors::ACUANT
@@ -484,14 +472,5 @@ def store_failed_images(client_response, doc_pii_response)
     def image_resubmission_check?
       IdentityConfig.store.doc_auth_check_failed_image_resubmission_enabled
     end
-
-    def phone_with_camera
-      case params[:phone_with_camera]
-      when 'true'
-        true
-      when 'false'
-        false
-      end
-    end
   end
 end

app/policies/idv/flow_policy.rb

@@ -53,7 +53,6 @@ def steps
         welcome: Idv::WelcomeController.step_info,
         agreement: Idv::AgreementController.step_info,
         how_to_verify: Idv::HowToVerifyController.step_info,
-        phone_question: Idv::PhoneQuestionController.step_info,
         hybrid_handoff: Idv::HybridHandoffController.step_info,
         link_sent: Idv::LinkSentController.step_info,
         document_capture: Idv::DocumentCaptureController.step_info,

app/services/analytics_events.rb

@@ -290,15 +290,12 @@ def contact_redirect(redirect_url:, step: nil, location: nil, flow: nil, **extra
   end
 
   # @param [String] message the warning
-  # @param [String] phone_question_ab_test_bucket Prompt user with phone question before doc auth
   # Logged when there is a non-user-facing error in the doc auth process, such as an unrecognized
   # field from a vendor
-  def doc_auth_warning(message: nil,
-                       phone_question_ab_test_bucket: nil, **extra)
+  def doc_auth_warning(message: nil, **extra)
     track_event(
       'Doc Auth Warning',
       message: message,
-      phone_question_ab_test_bucket: phone_question_ab_test_bucket,
       **extra,
     )
   end
@@ -904,17 +901,6 @@ def idv_doc_auth_link_sent_visited(**extra)
     track_event('IdV: doc auth link_sent visited', **extra)
   end
 
-  # The "phone question" step: Desktop user has submitted they
-  # do or do not have a phone with a a camera via desktop
-  def idv_doc_auth_phone_question_submitted(**extra)
-    track_event(:idv_doc_auth_phone_question_submitted, **extra)
-  end
-
-  # Desktop user has reached the above "phone question" view
-  def idv_doc_auth_phone_question_visited(**extra)
-    track_event(:idv_doc_auth_phone_question_visited, **extra)
-  end
-
   def idv_doc_auth_randomizer_defaulted
     track_event(
       'IdV: doc_auth random vendor error',
@@ -949,8 +935,6 @@ def idv_doc_auth_ssn_visited(**extra)
   # @param [String] flow_path
   # @param [String] front_image_fingerprint Fingerprint of front image data
   # @param [String] back_image_fingerprint Fingerprint of back image data
-  # @param [String] phone_question_ab_test_bucket Prompt user with phone question before doc auth
-  # @param [String] phone_with_camera the result of the phone question a/b test
   # The document capture image uploaded was locally validated during the IDV process
   def idv_doc_auth_submitted_image_upload_form(
     success:,
@@ -961,8 +945,6 @@ def idv_doc_auth_submitted_image_upload_form(
     user_id: nil,
     front_image_fingerprint: nil,
     back_image_fingerprint: nil,
-    phone_question_ab_test_bucket: nil,
-    phone_with_camera: nil,
     **extra
   )
     track_event(
@@ -975,8 +957,6 @@ def idv_doc_auth_submitted_image_upload_form(
       flow_path: flow_path,
       front_image_fingerprint: front_image_fingerprint,
       back_image_fingerprint: back_image_fingerprint,
-      phone_question_ab_test_bucket: phone_question_ab_test_bucket,
-      phone_with_camera: phone_with_camera,
       **extra,
     )
   end
@@ -996,8 +976,6 @@ def idv_doc_auth_submitted_image_upload_form(
   # @param [Float] vendor_request_time_in_ms Time it took to upload images & get a response.
   # @param [String] front_image_fingerprint Fingerprint of front image data
   # @param [String] back_image_fingerprint Fingerprint of back image data
-  # @param [String] phone_question_ab_test_bucket Prompt user with phone question before doc auth
-  # @param [String] phone_with_camera the result of the phone question a/b test
   # The document capture image was uploaded to vendor during the IDV process
   def idv_doc_auth_submitted_image_upload_vendor(
     success:,
@@ -1014,8 +992,6 @@ def idv_doc_auth_submitted_image_upload_vendor(
     vendor_request_time_in_ms: nil,
     front_image_fingerprint: nil,
     back_image_fingerprint: nil,
-    phone_question_ab_test_bucket: nil,
-    phone_with_camera: nil,
     **extra
   )
     track_event(
@@ -1035,8 +1011,6 @@ def idv_doc_auth_submitted_image_upload_vendor(
       vendor_request_time_in_ms: vendor_request_time_in_ms,
       front_image_fingerprint: front_image_fingerprint,
       back_image_fingerprint: back_image_fingerprint,
-      phone_question_ab_test_bucket: phone_question_ab_test_bucket,
-      phone_with_camera: phone_with_camera,
       **extra,
     )
   end
@@ -2346,6 +2320,7 @@ def idv_link_sent_capture_doc_polling_complete(
       isRateLimited: isRateLimited,
     )
   end
+
   # rubocop:enable Naming/VariableName,Naming/MethodParameterName
 
   def idv_link_sent_capture_doc_polling_started(**_extra)

app/services/idv/session.rb

@@ -16,7 +16,6 @@ class Session
       personal_key
       personal_key_acknowledged
       phone_for_mobile_flow
-      phone_with_camera
       pii_from_doc
       previous_phone_step_params
       profile_id