LG-11634: remove phone question and logging from backend#9675
LG-11634: remove phone question and logging from backend#9675dawei-nava merged 8 commits intomainfrom
Conversation
dawei-nava
force-pushed
the
dwang/LG-11634-remove-phone-question
branch
from
d7180fb to
ebf17b7
Compare
dawei-nava
requested review from
amirbey,
charleyf,
eileen-nava,
night-jellyfish and
soniaconnolly
| personal_key | ||
| personal_key_acknowledged | ||
| phone_for_mobile_flow | ||
| phone_with_camera |
There was a problem hiding this comment.
This session attribute removal should be okay to deploy at the same time as deleting the controller that uses it, because the feature flag has been turned off for a while.
| get '/phone_question' => 'phone_question#show' | ||
| get '/phone_question/phone_with_camera' => 'phone_question#phone_with_camera' | ||
| get '/phone_question/phone_without_camera' => 'phone_question#phone_without_camera' |
There was a problem hiding this comment.
Do we want to change these to redirects to hybrid handoff so that a user with a bookmark doesn't get a 404?
There was a problem hiding this comment.
@soniaconnolly , what are our common practice here, is this standard practice?
There was a problem hiding this comment.
@soniaconnolly , ok did some testing. I copied the hybrid-handoff page url(essentially bookmark it), then I close the browser.
Revisit loging.gov, it asks me to login, and then I go directly to http://localhost:3000/verify/hybrid_handoff, it lands on welcome page. So i think without a valid doc auth session, it will start from the beginning.
eileen-nava
left a comment
eileen-nava
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for taking care of this PR, I know it was a lot of changes. 🙏🏻
…age logic from backend
4 participants
🎫 Ticket
LG-11634: remove phone question and logging from backend
🛠 Summary of changes
This removes completely phone question page and ab testing related code in the backend.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.