Skip to content

LG-11638 Revert PO Related Content#9659

Merged
gina-yamada merged 6 commits intomainfrom
LG-11638-Revert-PO-Related-Content
Nov 27, 2023
Merged

LG-11638 Revert PO Related Content#9659
gina-yamada merged 6 commits intomainfrom
LG-11638-Revert-PO-Related-Content

Conversation

@gina-yamada
Copy link
Contributor

@gina-yamada gina-yamada commented Nov 27, 2023

🎫 Ticket

LG-11638 Revert PO-related content changes in DocAuth error and Prepare pages

🛠 Summary of changes

  • Revert most of the changes in PR#9494 (I kept a few new tests that and just removed some of the assertions, I kept lower casing of Post Office in Spanish translation file)
  • Revert content & translations on /verify/document_capture view
  • Revert content & translations on /verify/doc_auth/document_capture#prepare

📜 Testing Plan

  • Step 1 Create an account and start to identity your identity, upload images so that you fail proofing
  • Step 2 Inspect content at url /verify/document_capture to confirm all updates are made
  • Step 3 Click Try in person
  • Step 4 Inspect content at url /verify/document_capture#prepare to confirm all updates are made
  • Step 5 Repeat steps 2-4 for Spanish and French translations

👀 Screenshots

👀 Screenshots for verify/document_capture

Screenshot 2023-11-27 at 9 16 21 AM

Screenshot 2023-11-27 at 9 17 12 AM

Screenshot 2023-11-27 at 9 17 40 AM

👀 Screenshots for verify/document_capture#prepare

Screenshot 2023-11-27 at 9 16 45 AM

Screenshot 2023-11-27 at 9 17 20 AM

Screenshot 2023-11-27 at 9 17 46 AM

Copy link
Contributor

@n1zyy n1zyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran this through manual testing and it all looks good!

@gina-yamada
Copy link
Contributor Author

gina-yamada commented Nov 27, 2023

Updated translation here for prompt_detail

Updated text in prompt details after talking with @WheresHJ and @carmenrosalop

Screenshot 2023-11-27 at 12 49 02 PM

Screenshot 2023-11-27 at 12 49 38 PM

Screenshot 2023-11-27 at 12 50 12 PM

Only one instance of prompt_details found in code, outside of yml (translation) and spec (testing) file, so this change will not affect other areas in the app.

Screenshot 2023-11-27 at 12 51 17 PM

@carmenrosalop carmenrosalop self-requested a review November 27, 2023 20:02
Copy link

@carmenrosalop carmenrosalop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@gina-yamada gina-yamada merged commit 534cd4e into main Nov 27, 2023
@gina-yamada gina-yamada deleted the LG-11638-Revert-PO-Related-Content branch November 27, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants