Update good_job to include bug fix for polling feature#9643
Merged
mitchellhenke merged 1 commit intomainfrom Nov 24, 2023
Merged
Update good_job to include bug fix for polling feature#9643mitchellhenke merged 1 commit intomainfrom
mitchellhenke merged 1 commit intomainfrom
Conversation
zachmargolis
approved these changes
Nov 22, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
other than base64, LGTM
Gemfile.lock
Outdated
Contributor
There was a problem hiding this comment.
same comment as here, I'm wary of upgrading base64 at this time
Contributor
Author
There was a problem hiding this comment.
Removed the base64 update from this PR
changelog: Internal, Dependencies, Update good_job
mitchellhenke
force-pushed
the
mitchellhenke/update-good-job-4
branch
from
e67ea41 to
380af53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
bensheldon/good_job#1148 includes a fix to a bug with a feature/configuration that we use. This PR updates good_job to a version that includes the patch.