Update ReportMailer to use EmailableReports struct#9408
Merged
zachmargolis merged 3 commits intomainfrom Oct 18, 2023
Merged
Conversation
zachmargolis
commented
Oct 18, 2023
Contributor
Author
There was a problem hiding this comment.
cc @Sgtpluck tagging you on this PR just as a heads up that I refactored this report you added
ThatSpaceGuy
approved these changes
Oct 18, 2023
Contributor
ThatSpaceGuy
left a comment
ThatSpaceGuy
left a comment
There was a problem hiding this comment.
Looks good - thanks!
- Removes options hash, makes options first-class propreties - Refactors existing reports changelog: Internal, Reporting, Update reporting email to use struct internally
zachmargolis
force-pushed
the
margolis-emailable-table-struct
branch
from
ec25893 to
e4d2d29
Compare
Merged
zachmargolis
added a commit
that referenced
this pull request
Feb 5, 2025
- Options were removed as part of refactor in #9408 changelog: Internal, Source code, Update source documentation
zachmargolis
added a commit
that referenced
this pull request
Feb 5, 2025
- Options were removed as part of refactor in #9408 changelog: Internal, Source code, Update source documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(I'm branching off of #9405 because I didn't want to deal with merge conflicts in the
report_mailer.rbfile)