Add option to collect multiple tables into a single .xlsx (LG-11200)#9405
Merged
zachmargolis merged 4 commits intomainfrom Oct 18, 2023
Merged
Add option to collect multiple tables into a single .xlsx (LG-11200)#9405zachmargolis merged 4 commits intomainfrom
zachmargolis merged 4 commits intomainfrom
Conversation
changelog: Internal, Reporting, Attach monthly key metrics report as .xlsx
olatifflexion
approved these changes
Oct 18, 2023
ThatSpaceGuy
approved these changes
Oct 18, 2023
Contributor
ThatSpaceGuy
left a comment
ThatSpaceGuy
left a comment
There was a problem hiding this comment.
Nice, thanks for knocking this one out!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11200
🛠 Summary of changes
attachment_formatoption to the sharedReportMailer.tables_reportcaxlsxgem has nice writing options compared to others, but no reading options, so we pull in two gems