Skip to content

LG-11190 Don't reset the SSN rate limit on successful submission #9371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmhooper merged 1 commit into from
Oct 13, 2023
Merged

LG-11190 Don't reset the SSN rate limit on successful submission #9371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/controllers/concerns/idv/verify_info_concern.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,6 @@ def save_threatmetrix_status(form_response)
def summarize_result_and_rate_limit_failures(summary_result)
if summary_result.success?
add_proofing_components
ssn_rate_limiter.reset!
else
idv_failure(summary_result)
end
Expand Down
4 changes: 2 additions & 2 deletions spec/features/idv/doc_auth/verify_info_step_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@
expect(page).to have_current_path(idv_verify_info_path)
end

context 'resolution throttling' do
context 'resolution rate limiting' do
let(:max_resolution_attempts) { 3 }
before do
allow(IdentityConfig.store).to receive(:idv_max_attempts).
Expand Down Expand Up @@ -196,7 +196,7 @@
end
end

context 'ssn throttling' do
context 'ssn rate limiting' do
# Simulates someone trying same SSN with second account
let(:max_resolution_attempts) { 4 }
let(:max_ssn_attempts) { 3 }
Expand Down