LG-11190 Don't reset the SSN rate limit on successful submission#9371
Merged
LG-11190 Don't reset the SSN rate limit on successful submission#9371
Conversation
Prior to this commit we reset the ss rate limiter on success. This was done to prevent users from being rate limited after successfully completing a step. The logic that caused that issue was addressed in #9343. This commit starts counting successful attempts to towards the rate limit. This protects our users from fraud and makes it easier for us to make this step re-entrant to support the back button. changelog: Improvements, Rate Limiting, The proof ssn rate limiter was modified to no longer reset on successful proofing attempts that include an ssn
Contributor
Author
|
Here is where you can find the existing tests that ensure the SSN rate limiter is working: https://github.com/18F/identity-idp/blob/jmhooper-dont-reset-ssn-rate-limit/spec/features/idv/doc_auth/verify_info_step_spec.rb#L199-L241 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit we reset the ss rate limiter on success. This was done to prevent users from being rate limited after successfully completing a step. The logic that caused that issue was addressed in #9343.
This commit starts counting successful attempts to towards the rate limit. This protects our users from fraud and makes it easier for us to make this step re-entrant to support the back button.