Merged
Conversation
* LG-10912 Reformat Account Reuse Report changelog: Internal, formatting, un-embed the CSV from within JSON
Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.10.43 to 1.10.44. - [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.10.43...v1.10.44) --- updated-dependencies: - dependency-name: libphonenumber-js dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add in_person_verification_needed argument to profile_maker#save_profile we no longer pass in_person_verification_pending to the initialize method for profile maker * added profile#deactivate_for_in_person_verification added this method and split from profile#deactivate_for_in_person_verification_and_schedule_enrollment * profile#activate_after_passing_in_person nils out in person timestamp * use new profile#deactivate_for_in_person_verification method * separated schedule and deactivate for ipp in gpo verify form * removed profile#deactivate_for_in_person_verification_and_schedule_enrollment removed this method as coupling them didn't work when creating a profile for phone finder. --------- changelog: Internal, IdV IPP, write to in_person_verification_pending_at Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov> Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
- Tested with bin/query-cloudwatch, bin/oncall/* [skip changelog]
…up (#9119) * changelog: User-Facing Improvements, MFA Setup, Bug-fix for inconsistent enforcement of phishing-resistant account. * fix issue at sign in * lint fix * optimize logic to check user has minimum required * remove change to spec that wasn't needed * remove unneeded variable
[skip changelog]
…cation OIDC request (LG-10936) (#9157) * Do not end session when switching languages during forced re-authentication OIDC request changelog: Bug Fixes, OpenID Connect, Do not end session when switching languages during forced re-authentication request * Update spec/controllers/openid_connect/authorization_controller_spec.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> (cherry picked from commit 6b221d2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal